-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[arrow:x64-linux] [brotli:x64-linux] Can not be used together. #9838
Comments
It seems we either need to patch or change the current patch of brotli vcpkg/ports/brotli/install.patch Line 53 in f272b0c
|
After more investigation it seems like multiple dependencies can't be found which has it's own
In case of lz4, vcpkg provides the CMakeLists.txt, so it should be |
Consuming Arrow seems to be more manual than we'd like. ParquetSharp's How do we go about fixing this stuff? Ideally we don't want to have to maintain a lot of patching in the Arrow port to rename the dependencies Arrow looks for. By the way, Arrow has recently been updated to v0.16 in vcpkg. |
@philjdf is correct. Whoever manages to patch ParquetSharp such that it builds from vcpkg cmake toolchain without needing custom Every time we tried, it ended up in tears. |
Actually, I don't see any other solution than patching arrow. (And adding cmake config for zstd.)
I changed the target names to match the vcpkg ones and now I can use arrow without any problems. |
Getting everything to agree what everything is called seems hard. It would be nice if there were strong Vcpkg guidelines on the right way of doing stuff. Last time I checked it was still missing that. Re your comment about sed. Is your thinking to just make it easy for each port to have local names for dependencies in vcpkg? E.g. what it wants to call |
I was actually thinking patching arrow with sed instead of maintaining patches, but your idea is much cleaner. |
IIUC the original brotli issues were resolved with the port pdate to 8.0.0 (#24714). |
Describe the bug
I built arrow with
vcpkg install arrow
. It built everything fine, it built all the dependencies one of which is brotli.Now I try to build an application using it. Since it is linux, the build is static, so I need to add all dependencies to my project. Which I can not...
Here is the issue:
arrow expects a target named
Brotli::brotlienc
:but brotli exports
unofficial::brotli::brotlienc
:vcpkg/ports/brotli/install.patch
Line 53 in f272b0c
Environment
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Obviously it should just work. I don't know which other projects using Brotli, but it is safe to say they are also broken. If the
Brotli::
namespace is generally used, I think vcpkg should use the same. If not, vcpkg should patch arrow to use theunofficial::brotli::
namespace.The text was updated successfully, but these errors were encountered: