-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI results should yield INCONCLUSIVE if ports that were changed could not be tested #13533
Comments
Generally speaking, the PR system doesn't know what ports you "edited" -- the way we currently figure out how they're edited is via the binary caching system. We find the hash of all the things, and rebuild anything which isn't in the cache. That said, CASCADE results should really be in |
We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info. |
@BillyONeal this bit me again. #16953 was showing CASCADE for windows static build, which I admittedly did not notice, nor did anyone else for that matter. It got merged and ended up causing all other PRs to fail, until fixed by #18116. @JackBoosY I believe this issue should very much stay open, as it continues to be relevant and causes trouble. |
@wrobelda This because
In my opinion, |
@JackBoosY @BillyONeal this issue should remain open for as long as this has not been resolved. It continues (#19945 (comment)) to mislead your contributors and not acknowledging the issue leads to frustration to say the least, not to mention the accidental approvals of PRs (as exemplified in my original comment). |
Describe the bug
Your CI currently returns Success results even if the ports that were changed as part of the PR were not actually being tested for whatever reason. I already got bit by it significantly and almost successfully pushed a non-functional PR that was previously LGTM-ed by two of the maintainers.
Please also note that some more devs who previously contributed to this project also were affected by this issue.
To Reproduce
Expected behavior
The text was updated successfully, but these errors were encountered: