[libtasn1] Add Windows support, update to 4.17 #16953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrobelda
changed the title
|
Currently stuck at: Something's off with linker, it fails to resolve own symbols, as well as generated executables (e.g. |
|
OK, so what I see is: followed by: The missing symbols are in |
|
Most interestingly, the problematic |
|
I tried setting the LDFLAGS using env variable instead ( EDIT: Gonna try with |
|
OK, so I tried setting the LDFLAGS using CONFIGURE_ENVIRONMENT_VARIABLES to see if it makes any difference, but it doesn't: the This is clearly some bug. |
NancyLi1013
added
the
category:port-feature
|
That is probably a bug in a |
Well, actually, I read too much into the command line, while forgetting to check the obvious: the However, the Checking further. EDIT: also checking libtool's |
|
OK, so this is till to do with overloading LDFLAGS. From the build log: It fails to find Setting LDFLAGS with Not setting it will get: So: |
wrobelda
force-pushed
the
libtasn1_windows
branch
from
6835804
to
2adedd6
Compare
|
Given how vcpkg already configured LDFLAGS as required, I only needed to set the LIBS. This was also problematic, given how setting the environment variable would override vcpkg's own list of libraries ( I worked around by passing LIBS as a regular option to vcpkg_configure_make and have it use shell to expand the environment LIB variable at the time of execution: |
wrobelda
force-pushed
the
libtasn1_windows
branch
6 times, most recently
from
2cc70e3
to
713059e
Compare
|
Build still fails on CI/CD, but I cannot reproduce those errors locally on my Windows dev box: Line 77 of Everything compiles fine for me locally. Could be it a different MSVC version? |
|
The latest failures on Windows: From build-x64-windows-dbg-err.log Could you please look into this? @wrobelda |
wrobelda
force-pushed
the
libtasn1_windows
branch
2 times, most recently
from
fcd0e65
to
c5a5c42
Compare
|
EDIT: the below is fixed now OK, I am stuck, tbh. The build fails differently for x86 and x64 platforms. On x86 I am seeing: And on x64: With the stderr being: The x64 libtool call seems to reference |
wrobelda
force-pushed
the
libtasn1_windows
branch
from
45b811b
to
b57c8eb
Compare
wrobelda
changed the title
wrobelda
force-pushed
the
libtasn1_windows
branch
from
ea2f8f0
to
a049843
Compare
wrobelda
force-pushed
the
libtasn1_windows
branch
from
a049843
to
19bea73
Compare
wrobelda
force-pushed
the
libtasn1_windows
branch
from
19bea73
to
aa2a47e
Compare
|
@NancyLi1013 all issues are fixed now. |
NancyLi1013
reviewed
May 20, 2021
NancyLi1013
added
the
category:port-update
NancyLi1013
approved these changes
May 20, 2021
NancyLi1013
added
info:reviewed
|
LGTM now. thanks for your work @wrobelda. |
dg0yt
reviewed
May 20, 2021
|
LGTM! Thanks @wrobelda :) |
|
CI baseline regression in static builds: |
Just realized that the most recent CI/CD build was |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 25, 2021
@Neumann-A OK, I thought it was about the Your log section corresponds to |
Please notice the prefix Edit: extern ASN1_API int
asn1_parser2tree (const char *file,
asn1_node * definitions, char *error_desc);#ifndef ASN1_API
#if defined ASN1_BUILDING && defined HAVE_VISIBILITY && HAVE_VISIBILITY
#define ASN1_API __attribute__((__visibility__("default")))
#elif defined ASN1_BUILDING && defined _MSC_VER && ! defined ASN1_STATIC
#define ASN1_API __declspec(dllexport)
#elif defined _MSC_VER && ! defined ASN1_STATIC
#define ASN1_API __declspec(dllimport)
#else
#define ASN1_API
#endif
#endifI can confirm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Enables windows build
static-md build is unsupported. CI baseline updated.
Yes.