Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl] Visualization headers are not installed #15130

Closed
JorgeRomeoInfaimon opened this issue Dec 15, 2020 · 21 comments · Fixed by #18855 or #21788
Closed

[pcl] Visualization headers are not installed #15130

JorgeRomeoInfaimon opened this issue Dec 15, 2020 · 21 comments · Fixed by #18855 or #21788
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision

Comments

@JorgeRomeoInfaimon
Copy link

When pcl libraries are installed, I am trying to compile some samples found in the tutorials, but I cannot compile because the pcl/visualization headers cannot be found.

They do not exist in vcpkg/installed/include directory. Maybe they should be installed and the required components compiled.

@JorgeRomeoInfaimon JorgeRomeoInfaimon changed the title [pcl] Viauslization headers are not installed [pcl] Visualization headers are not installed Dec 15, 2020
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 15, 2020
@JackBoosY
Copy link
Contributor

I think if we need to use the feature visualization, we should enable the feature vtk first.
Will check later.

@JackBoosY
Copy link
Contributor

-- The following subsystems will not be built:
--   visualization: VTK was not found.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Dec 17, 2020
@JackBoosY
Copy link
Contributor

CMake Deprecation Warning at F:/vcpkg/installed/x86-windows/share/vtk/vtk-config.cmake:64 (message):
  The new name for the 'vtkChartsCore' component is 'ChartsCore'
Call Stack (most recent call first):
  F:/vcpkg/scripts/buildsystems/vcpkg.cmake:625 (_find_package)
  CMakeLists.txt:394 (find_package)


CMake Deprecation Warning at F:/vcpkg/installed/x86-windows/share/vtk/vtk-config.cmake:64 (message):
  The new name for the 'vtkCommonCore' component is 'CommonCore'
Call Stack (most recent call first):
  F:/vcpkg/scripts/buildsystems/vcpkg.cmake:625 (_find_package)
  CMakeLists.txt:394 (find_package)
...
CMake Warning at F:/vcpkg/scripts/buildsystems/vcpkg.cmake:625 (_find_package):
  Found package configuration file:

    F:/vcpkg/installed/x86-windows/share/vtk/vtk-config.cmake

  but it set VTK_FOUND to FALSE so package "VTK" is considered to be NOT
  FOUND.  Reason given by package:

  Could not find the VTK package with the following required components:
  RenderingContextOpenGL.

After searching for this issue from upstream(PointCloudLibrary/pcl#4412), I found that pcl does not support VTK 9.0 in our master branch now.
Waiting for upstream fix this issue(PointCloudLibrary/pcl#4262).

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Dec 17, 2020
@VXallset
Copy link

Any update pls?

@JackBoosY
Copy link
Contributor

@VXallset Waiting for official fix.

@HelliceSaouli
Copy link

What should we do can we use some old version ?

@JackBoosY JackBoosY removed the depends:upstream-changes Waiting on a change to the upstream project label Mar 1, 2021
@JackBoosY
Copy link
Contributor

PointCloudLibrary/pcl#4262 was merged, I will handle this issue in the nearly future.

@JackBoosY
Copy link
Contributor

Since the changes is huge, I think we should wait for the next release of pcl.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Mar 19, 2021
@JorgeRomeoInfaimon
Copy link
Author

Understood. Thanks for your hard work!

@tungts1101
Copy link

As missing the visualizer header is quite cumbersome in visualizing data, should you recommend a proper way to install an older version of PCL with vcpkg?

@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision and removed depends:upstream-changes Waiting on a change to the upstream project labels Jun 21, 2021
@JackBoosY
Copy link
Contributor

We should update to 1.11.1.

@JackBoosY
Copy link
Contributor

Hi guys, since pcl was updated to 1.11.1 in vcpkg, is this issue resolved?

@JackBoosY JackBoosY removed the category:port-update The issue is with a library, which is requesting update new revision label Jun 22, 2021
@HelliceSaouli
Copy link

@JackBoosY still the same issue

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jun 23, 2021
@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label Jun 23, 2021
@JackBoosY
Copy link
Contributor

The version 1.11.1 doesn't include the changes, waiting for 1.11.2 release.

@HelliceSaouli
Copy link

1.12.0 is out you guys any news here .??

@JackBoosY JackBoosY removed the depends:upstream-changes Waiting on a change to the upstream project label Jul 7, 2021
@JonLiu1993 JonLiu1993 added the depends:upstream-changes Waiting on a change to the upstream project label Jul 7, 2021
@JonLiu1993
Copy link
Member

@HelliceSaouli ,Currently pcl1.12.0 is released as a pre-release version. Users may have problems when using it. It will be updated after the official version is released according to our policy.

@raahilsha-z
Copy link
Contributor

raahilsha-z commented Jul 7, 2021

PCL just pushed their release a couple hours ago, and I've opened a pull request here with those changes:

#18855

Tested with vcpkg install pcl[core,cuda,opengl,qt,vtk]:x64-windows

@HelliceSaouli
Copy link

EPIC, Thank you guys

@JackBoosY JackBoosY linked a pull request Jul 8, 2021 that will close this issue
@YhQIAO
Copy link

YhQIAO commented Sep 22, 2021

Is this issue fixed in 2021.9?

@JackBoosY
Copy link
Contributor

@YhQIAO See #18855 (comment).

@JackBoosY
Copy link
Contributor

I confirmed this feature is still not added, I will open a PR to add it.

@JackBoosY JackBoosY reopened this Dec 1, 2021
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed depends:upstream-changes Waiting on a change to the upstream project labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
8 participants