Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VTK 9 #4262

Merged
merged 15 commits into from
Feb 16, 2021
Merged

Add support for VTK 9 #4262

merged 15 commits into from
Feb 16, 2021

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Jul 10, 2020 •
edited
Loading

Closes #4138, closes #4096.

@larshg larshg force-pushed the pr/n4096_VTK9.0 branch from c3a8fb6 to 7f8020c Compare July 14, 2020 21:20
@larshg larshg mentioned this pull request Jul 30, 2020
Closed
@larshg larshg force-pushed the pr/n4096_VTK9.0 branch from fdb7531 to dab5065 Compare July 30, 2020 17:57
@kunaltyagi
Copy link
Member

Please run make format and commit+push to pass the first CI 😄

@larshg larshg force-pushed the pr/n4096_VTK9.0 branch 3 times, most recently from cdd5174 to c2dcc3e Compare August 4, 2020 19:14
@larshg
Copy link
Contributor Author

larshg commented Aug 11, 2020

Is draft PRs not run by CI anymore?

@larshg larshg marked this pull request as ready for review August 11, 2020 18:10
@kunaltyagi
Copy link
Member

kunaltyagi commented Aug 12, 2020 •
edited
Loading

Is draft PRs not run by CI anymore?

It never was

@larshg larshg mentioned this pull request Aug 12, 2020
Closed
@larshg larshg force-pushed the pr/n4096_VTK9.0 branch 2 times, most recently from 676c514 to 3ea863e Compare August 12, 2020 19:10
@Neumann-A Neumann-A mentioned this pull request Aug 12, 2020
Closed
@larshg larshg force-pushed the pr/n4096_VTK9.0 branch 2 times, most recently from 18564c3 to fda2704 Compare August 13, 2020 04:35
@kunaltyagi
Copy link
Member

Please rebase to get the latest release pipeline CI. Current version forces release CI to be run always

@larshg larshg force-pushed the pr/n4096_VTK9.0 branch 4 times, most recently from 217be3a to 3d8a6d7 Compare August 16, 2020 08:25
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.12.0 milestone Aug 17, 2020
kunaltyagi
kunaltyagi reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15/71

apps/CMakeLists.txt Show resolved Hide resolved
apps/cloud_composer/CMakeLists.txt Outdated Show resolved Hide resolved
apps/cloud_composer/include/pcl/apps/cloud_composer/cloud_view.h Outdated Show resolved Hide resolved
kunaltyagi
kunaltyagi reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

34/71

doc/tutorials/content/sources/qt_colorize_cloud/CMakeLists.txt Outdated Show resolved Hide resolved
doc/tutorials/content/sources/qt_visualizer/pclviewer.cpp Outdated Show resolved Hide resolved
gpu/kinfu/tools/CMakeLists.txt Outdated Show resolved Hide resolved
people/CMakeLists.txt Show resolved Hide resolved
visualization/include/pcl/visualization/vtk.h Show resolved Hide resolved
visualization/include/pcl/visualization/vtk/pcl_vtk_compatibility.h Outdated Show resolved Hide resolved
visualization/include/pcl/visualization/vtk/pcl_vtk_compatibility.h Show resolved Hide resolved
@kunaltyagi
Copy link
Member

@larshg 🚀 ?

@larshg
Copy link
Contributor Author

larshg commented Feb 10, 2021

Yes please, lets get it merged so we can get a swarm of issues about VTK9 🤣

@kunaltyagi
Copy link
Member

LGTM. I'll let you do the honors of merging this 🥳 🎆 🎊

@larshg larshg merged commit e0a2e7b into PointCloudLibrary:master Feb 16, 2021
@larshg
Copy link
Contributor Author

larshg commented Feb 16, 2021

Woot 🥳

@Neumann-A
Copy link

So when will be the next tagged release?

@larshg
Copy link
Contributor Author

larshg commented Feb 16, 2021

So when will be the next tagged release?

That's a great question. Since there are still a few issue left on the milestone, but maybe... some of them should be moved for the next :)
https://github.com/PointCloudLibrary/pcl/milestone/10

@larshg larshg deleted the pr/n4096_VTK9.0 branch February 16, 2021 21:39
This was referenced Feb 19, 2021
Closed
Closed
Closed
Closed
Closed
@larshg larshg mentioned this pull request Mar 16, 2021
Merged
@SunBlack SunBlack mentioned this pull request Apr 17, 2021
Merged
@drhpc
Copy link

drhpc commented Apr 28, 2021

About the milestones and releasing this fix … please consider releasing such changes as minor/bugfix versions. I'll have to pull in the change anyway when packaging this for an environment that has vtk 9, like I right now have to pull in PR 4540 since the still-current release relies on qhull API that has long been deprecated.

When you are in this ecosystem of dependencies that put pressure on users even being able to build PCL at all, it would be nice to consider such build fixes/updates separately from any milestone goals about features. Saves a lot of pain for packagers, especially, who usually are not at the liberty of picking a preferred version of any dependency when there is another in the repository/distribution.

@Tobias-Fischer Tobias-Fischer mentioned this pull request May 12, 2021
Merged
5 tasks
@larshg larshg mentioned this pull request Jul 11, 2021
Closed
@mrwsl mrwsl mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

@mvieth mvieth mvieth approved these changes

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: cmake module: visualization needs: code review Specify why not closed/merged yet needs: more work Specify why not closed/merged yet needs: pr merge Specify why not closed/merged yet
Projects
None yet
Milestone
pcl-1.12.0
8 participants
@larshg @kunaltyagi @opoplawski @Jensbeltman @Neumann-A @drhpc @mvieth @SergioRAgostinho