-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vtk to build visualization #31
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is needed to build rtabmap in the RoboStack project |
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.03.31.16.02.06
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.03.31.16.02.06
@conda-forge-admin, please rerender |
…da-forge-pinning 2021.04.01.12.45.45
I'm worried that VTK and QT dependencies of PCL are going to make it difficult to bump versions and rerender in the future. VTK and QT (QT especially) are not upgraded at their normal release pace in Conda/Forge. I don't know if it is possible to create a sub package or something that makes this part of PCL optionally installed. It is probably a lot more effort than it is worth. |
We can create two variants, one with QT/VTK and one without. I'll try getting it to build first, and then introduce the variant. |
If it is a big hassle don't worry about it. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.04.10.19.49.31
Is there some way to enforce pulling in the most recent build? Osx fails because it pulls in the previous build of vtk (build num 6), not the very latest build (build num 7) |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.04.29.13.58.20
Hi @hobu @chambbj, It would be great if you could have a look and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. Objections @hobu?
@Tobias-Fischer I guess I will only add that it could be helpful to cross-reference the patch to the PCL fix so that it is a little more obvious when we can back out the patch. E.g., patch |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)