-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hunspell] build failure #17374
Comments
Can you re-install gettext using apt again? Thanks. |
I don't install gettext using apt - vcpkg pulls it in:
Would you like me to pre-install it using apt for a text? |
Sorry for late, does this issue still exist? |
Yes - and it's an issue because it's blocking an update to the latest vcpkg, which is one of the solutions for fixing the Using commit d417ae5 gives the following error logs (thank you for showing them inline now):
|
Seems like it is related to #13518? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hunspell installs fine in the November 2020 version of vcpkg - something to keep in mind is that this is a regression. |
Oh, the last minute changes to #18159 seem to have disabled the tools for linux again. I need to stop allowing edits by maintainers. |
Using commit 7d2541c - on Windows a new transient dependency is introduced and it breaks the build first (#19117). On macOS hunspell fails:
On Ubuntu it works now, that is a step forward thanks 👍 all logs can be found here. |
You really need a few more packages via brew for macOS: the missing aclocal is probably part of |
So should we update to the latest to fix this issue? |
@JackBoosY The issue here is fixed now: Port hunspell already was complete (updating PATH), and the recent merge of #18159 added the missing tools for Linux. (The new issues in the last comments are not related to hunspell, but to missing autoconf/automake (macos) and unsuitable mingw32-make (mingw).) |
Just to note, the hunspell port did not require that tooling as of Nov 2020. Is it intended that it is now a required outside dependency? |
AFAICS port hunspell was build with a custom cmake build system (from vcpkg) in Nov 2020. Today the port uses the original build system. |
Makes sense 👍 |
I install both |
@vadi2 Can you please provide the failure logs? |
@vadi2 Please re-install Thanks. |
@vadi2 Your CI is broken. "(macOS) Install non-vcpkg dependencies" comes after "Restore from cache and run vcpkg". |
Thanks, fixed now. |
Seems like it is the way to go: microsoft/vcpkg#17374
Host Environment
Ubuntu 16.04 in github actions.
To Reproduce
Steps to reproduce the behavior:
./vcpkg install hunspell
Failure logs
out log:
err log:
Additional context
Worked fine as of 4b222f8, broken as of latest mater.
The text was updated successfully, but these errors were encountered: