Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cjson/libzen] [vcpkg_cmake_config_fixup] It doesn't fix up the ${_IMPORT_PREFIX} #20318

Closed
2 tasks
PhoebeHui opened this issue Sep 24, 2021 · 3 comments · Fixed by #20380
Closed
2 tasks

[cjson/libzen] [vcpkg_cmake_config_fixup] It doesn't fix up the ${_IMPORT_PREFIX} #20318

PhoebeHui opened this issue Sep 24, 2021 · 3 comments · Fixed by #20380
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@PhoebeHui
Copy link
Contributor

We found vcpkg_cmake_config_fixup doesn't work for the following ports, It doesn't fix up the ${_IMPORT_PREFIX} in cmake config and targets file. cc @strega-nil

  • cjson
  • libzen

eg:
cjson-debug.cmake:

#----------------------------------------------------------------
# Generated CMake target import file for configuration "Debug".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "cjson" for configuration "Debug"
set_property(TARGET cjson APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
set_target_properties(cjson PROPERTIES
  IMPORTED_IMPLIB_DEBUG "E:/vcpkg/src/vcpkg/packages/cjson_x86-windows/debug/lib/cjson.lib"
  IMPORTED_LOCATION_DEBUG "E:/vcpkg/src/vcpkg/packages/cjson_x86-windows/debug/bin/cjson.dll"
  )

list(APPEND _IMPORT_CHECK_TARGETS cjson )
list(APPEND _IMPORT_CHECK_FILES_FOR_cjson "E:/vcpkg/src/vcpkg/packages/cjson_x86-windows/debug/lib/cjson.lib" "E:/vcpkg/src/vcpkg/packages/cjson_x86-windows/debug/bin/cjson.dll" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)
  )
@PhoebeHui PhoebeHui added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Sep 24, 2021
@PhoebeHui PhoebeHui changed the title [vcpkg_cmake_config_fixup] It doesn't fix up the ${_IMPORT_PREFIX} [vcpkg_cmake_config_fixup][cjson/libzen] It doesn't fix up the ${_IMPORT_PREFIX} Sep 24, 2021
@PhoebeHui PhoebeHui changed the title [vcpkg_cmake_config_fixup][cjson/libzen] It doesn't fix up the ${_IMPORT_PREFIX} [cjson/libzen] [vcpkg_cmake_config_fixup] It doesn't fix up the ${_IMPORT_PREFIX} Sep 24, 2021
@strega-nil-ms
Copy link
Contributor

Unfortunately this isn't a bug in vcpkg that we should fix, this is a bug in these ports' build systems; we need to fix the build systems instead (and probably add a check to vcpkg-tool)

@strega-nil-ms strega-nil-ms added category:port-bug The issue is with a library, which is something the port should already support and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels Sep 27, 2021
@BillyONeal
Copy link
Member

Unfortunately this isn't a bug in vcpkg that we should fix, this is a bug in these ports' build systems; we need to fix the build systems instead (and probably add a check to vcpkg-tool)

@strega-nil @strega-nil-ms I think the issue fixed by #20380 where the wrong case of the variable was used is what this issue is about; is there something else you meant that vcpkg can't fix up?

@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Sep 28, 2021

oh, apparently I misunderstood! thanks @PhoebeHui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants