[vcpkg_cmake_config_fixup] Fix variable name #20380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
category:vcpkg-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
approved these changes
Sep 27, 2021
JackBoosY
added
info:world-rebuild
info:reviewed
2 tasks
|
Thanks for the case fixup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20318
vcpkg_cmake_config_fixup doesn't fix up the ${_IMPORT_PREFIX} in cmake config and targets file, I found the variable name CMAKE_CURRENT_PACKAGES_DIR haven't been repalced with cmake_current_packages_dir.
Test with cjson and libzen port, it solved the problems.