Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request CI ignores baseline records #23862

Closed
dg0yt opened this issue Mar 30, 2022 · 2 comments · Fixed by microsoft/vcpkg-tool#472 or #23886
Closed

Pull request CI ignores baseline records #23862

dg0yt opened this issue Mar 30, 2022 · 2 comments · Fixed by microsoft/vcpkg-tool#472 or #23886
Assignees
@BillyONeal @JackBoosY
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof

Comments

@dg0yt
Copy link
Contributor

dg0yt commented Mar 30, 2022

The PR CI now ignores the baseline records, i.e. it builds ports which are known to fail, resulting in unexpected passes for some ports and in unexpected failures (which should be cascade) in depending ports.
Evidence:
https://dev.azure.com/vcpkg/public/_build/results?buildId=69660
(qtinterfaceframework is "fail" since #23837)
https://dev.azure.com/vcpkg/public/_build/results?buildId=69648
(ompl:x64-osx is "fail", omplapp is cascade)

CC @BillyONeal.
This was referenced Mar 30, 2022
Merged
Merged
@dg0yt
Copy link
Contributor Author

dg0yt commented Mar 30, 2022

If I observe and understand correctly this issue also drags the 2 h llvm:x64-windows build caching issue into more PRs than before.
CC @BillyONeal

@JackBoosY JackBoosY added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Mar 30, 2022
@dg0yt dg0yt mentioned this issue Mar 30, 2022
Merged
@BillyONeal
Copy link
Member

Your parent-hashes work is so effective we didn't notice 😅

This was referenced Mar 30, 2022
Merged
Merged
@dg0yt dg0yt mentioned this issue Mar 30, 2022
Merged
@BillyONeal BillyONeal reopened this Mar 30, 2022
@BillyONeal BillyONeal added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Mar 30, 2022
@strega-nil-ms strega-nil-ms mentioned this issue Mar 30, 2022
Merged
@dg0yt dg0yt mentioned this issue Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillyONeal BillyONeal

@JackBoosY JackBoosY

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof
Projects
None yet
Milestone
No milestone
3 participants
@BillyONeal @dg0yt @JackBoosY