-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeglut] Update to 3.2.2, fix X11 dependencies #23807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/freeglut/portfile.cmake
This comment was marked as resolved.
This comment was marked as resolved.
qtinterfaceframework:x64-windows: Baseline regression |
CI bug: #23862 |
All checks green, no longer depending on other PR to fix baseline regression. |
One more change. Hard to believe how much breakage exists when you try to link apps, not libraries. |
Thanks! |
What does your PR fix?
Updates freeglut to 3.2.2.
Drops the gcc-10 patch: Upstream marked those declaration now as
extern
.Fixes glut lib
FREEGLUT_LIBRARIES
on Linux where CMake 3.22 would lack the library path for glut. In turn, this fixes a link error when buildingopencolorio[tools]
on Ubuntu 18.04.Fixes the lookup and export of dependencies related to X11. In turn, this fixes a build error for
libwebp[core,vwebp]
on Ubuntu 18.04:Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no (fail on arm64-windows, uwp, osx)
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes