Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl2-image/mixer/net/ttf] Update to exported targets names. #25284

Closed
FtZPetruska opened this issue Jun 17, 2022 · 2 comments · Fixed by #27627
Closed

[sdl2-image/mixer/net/ttf] Update to exported targets names. #25284

FtZPetruska opened this issue Jun 17, 2022 · 2 comments · Fixed by #27627
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@FtZPetruska
Copy link
Contributor

FtZPetruska commented Jun 17, 2022


Description

Recently, a major CMake rework was done in the SDL2 subprojects, adding a consistent naming for the targets. Unfortunately, the naming chosen is inconsistent with the one used by vcpkg's ports.

The new naming consists in:

  • The namespace SDL2_XXX:: where XXX is the name of the subproject
  • A static target SDL2_XXX::SDL_XXX-static linked to SDL2::SDL2-static
  • A dynamic target SDL2_XXX::SDL_XXX linked to SDL2::SDL2

Proposed solution

Adopt the naming chosen by the maintainers.

Alternatives

To avoid breaking existing projects/ports, the targets currently in use by vcpkg could be kept as an alias of the new one with a deprecation message, similar to what is currently done in SDL_ttf.

Additional context

Related PRs:

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jun 17, 2022
@FtZPetruska
Copy link
Contributor Author

Hello, I just wanted to update you about the upstream CMake changes.

The new target names have been shipped in the following stable releases:

In addition to the original issue, I noticed that the naming is also different between vcpkg's ports and the official releases when using find_package:

  • vcpkg uses sdl2-XXX
  • official releases use sdl2_XXX

@dg0yt
Copy link
Contributor

dg0yt commented Jul 16, 2022

Related: #25803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants