-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl2-image/mixer/net/ttf] Update to exported targets names. #25284
Labels
category:port-update
The issue is with a library, which is requesting update new revision
Comments
JackBoosY
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Jun 17, 2022
Hello, I just wanted to update you about the upstream CMake changes. The new target names have been shipped in the following stable releases:
In addition to the original issue, I noticed that the naming is also different between vcpkg's ports and the official releases when using
|
Related: #25803 |
matthiakl
added a commit
to matthiakl/widelands
that referenced
this issue
Aug 2, 2022
hessenfarmer
pushed a commit
to widelands/widelands
that referenced
this issue
Aug 2, 2022
Ahmad-fadl
pushed a commit
to Ahmad-fadl/widelands
that referenced
this issue
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Recently, a major CMake rework was done in the SDL2 subprojects, adding a consistent naming for the targets. Unfortunately, the naming chosen is inconsistent with the one used by vcpkg's ports.
The new naming consists in:
SDL2_XXX::
whereXXX
is the name of the subprojectSDL2_XXX::SDL_XXX-static
linked toSDL2::SDL2-static
SDL2_XXX::SDL_XXX
linked toSDL2::SDL2
Proposed solution
Adopt the naming chosen by the maintainers.
Alternatives
To avoid breaking existing projects/ports, the targets currently in use by vcpkg could be kept as an alias of the new one with a deprecation message, similar to what is currently done in SDL_ttf.
Additional context
Related PRs:
The text was updated successfully, but these errors were encountered: