Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem registry schema is missing baseline property #30939

Closed
davidmatson opened this issue Apr 18, 2023 · 8 comments
Closed

Filesystem registry schema is missing baseline property #30939

davidmatson opened this issue Apr 18, 2023 · 8 comments
Assignees
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@davidmatson
Copy link
Contributor

Describe the bug
The JSON schema for a custom filesystem registry is missing a property for "baseline". Docs indicate that this property is required. I assume the docs are correct - without this property, it's not clear how vcpkg would know which baseline to choose from the baseline.json file.

@LilyWangLL LilyWangLL added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Apr 18, 2023
@LilyWangLL
Copy link
Contributor

This vcpkg-schema-definitions.schema.json file added by Billy. cc @BillyONeal Could you please take a look this issue? Thanks in advance.

@davidmatson
Copy link
Contributor Author

I tested to confirm, and the "baseline" property is indeed required for filesystem registries, as the docs indicate. Without it, I get this error:

1>The dependency was not found in the baseline, indicating that the package did not exist at that time. This may be fixed by providing an explicit override version via the "overrides" field or by updating the baseline.

@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 23, 2023
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this issue Sep 26, 2023
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Mar 26, 2024
@davidmatson
Copy link
Contributor Author

/remove-stale

@davidmatson davidmatson changed the title Filesystem registry schema is missing baseline proprty Filesystem registry schema is missing baseline property Mar 26, 2024
@LilyWangLL LilyWangLL removed the Stale label Mar 26, 2024
@BillyONeal
Copy link
Member

I tested to confirm, and the "baseline" property is indeed required for filesystem registries, as the docs indicate. Without it, I get this error:

1>The dependency was not found in the baseline, indicating that the package did not exist at that time. This may be fixed by providing an explicit override version via the "overrides" field or by updating the baseline.

This can be avoided as long as there is some other constraint to choose the version to use, or overrides. It is clearly better to require it, but filesystem registries have been shipping in optional form for long enough that I think at this point the right thing to do is to just fix the docs to say what the product actually does

BillyONeal added a commit to BillyONeal/vcpkg-docs that referenced this issue Jul 26, 2024
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this issue Jul 26, 2024
@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jul 26, 2024
AugP pushed a commit to microsoft/vcpkg-docs that referenced this issue Jul 30, 2024
@davidmatson
Copy link
Contributor Author

Thanks, @BillyONeal!

BillyONeal added a commit to microsoft/vcpkg-tool that referenced this issue Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants