New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need setup include path for rc.exe (wtl fails to build) #556

Closed

wm1 opened this issue Jan 17, 2017 · 1 comment

Labels

category:vcpkg-bug

Contributor

wm1 commented Jan 17, 2017

Repro:

vcpkg integrate install
vcpkg install wtl
cd installed\x86-windows\share\wtl\samples\MemDlg
Add CMakeLists.txt as following:
add_executable(MemDlg WIN32 MemDlg.cpp MemDlg.rc)
Update stdafx.h and MemDlg.rc to use e.g. #include <wtl/atlapp.h> instead of <atlapp.h>
cmake, followed by msbuild

Result:

cpp builds fine, but rc file fails to find atlres.h

Cause of the failure:

In wtl the header file is needed for rc.exe
scripts\buildsystems\msbuild\vcpkg.targets sets up AdditionalIncludeDirectories for ClCompile but not for ResourceCompile.

ras0219-msft added the category:vcpkg-bug label

Contributor Author

wm1 commented Apr 7, 2017

fixed in pull request #915

wm1 closed this as completed

BillyONeal added a commit to BillyONeal/vcpkg that referenced this issue


          [qtinterfaceframework] Delete pathtools dependency and update dependa…

472926b

…bot tagged dependencies.

Pathtools does not work with Python 3.12 ( gorakhargosh/pathtools#13 ) and qtinterfaceframework says: - Use ``pathlib`` from the standard library, instead of pathtools (`microsoft#556 <https://github.com/gorakhargosh/watchdog/pull/556>`_)

BillyONeal added a commit to BillyONeal/vcpkg that referenced this issue


          [qtinterfaceframework] Delete pathtools dependency and update dependa…

1f6d24b

…bot tagged dependencies.

Pathtools does not work with Python 3.12 ( gorakhargosh/pathtools#13 ) and qtinterfaceframework says: - Use ``pathlib`` from the standard library, instead of pathtools (`microsoft#556 <https://github.com/gorakhargosh/watchdog/pull/556>`_)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment