Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdl2-mixer] Enable native MIDI support on macOS #10201

Merged
merged 1 commit into from
Feb 29, 2020
Merged

[sdl2-mixer] Enable native MIDI support on macOS #10201

merged 1 commit into from
Feb 29, 2020

Conversation

jgiannuzzi
Copy link
Contributor

Enable native MIDI support for sdl2-mixer on macOS, like it is done on Windows.

@GPSnoopy
Copy link
Contributor

I was just looking for this exact feature for https://github.com/GPSnoopy/BelgianChocolateDuke3D :-D

PhoebeHui
PhoebeHui requested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump the Version to '2.0.4-9' in CONTROL file?

Have you test the features locally?

@msftclas
Copy link

msftclas commented Feb 25, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@jgiannuzzi
Copy link
Contributor Author

Hi @PhoebeHui, I made the required change.

I tested the feature locally on macOS Catalina 10.15.3.
I also checked that MIDI was still working on Windows 10 1909 64bit.

PhoebeHui
PhoebeHui approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@JackBoosY
Copy link
Contributor

Need to test features.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 26, 2020
@jgiannuzzi
Copy link
Contributor Author

Hey @PhoebeHui and @JackBoosY, do you need anything from me before this can be merged?

@JackBoosY
Copy link
Contributor

Just waiting for merge this PR.

@strega-nil
Copy link
Contributor

Thanks y'all! This is awesome !

@strega-nil strega-nil merged commit 0babb75 into microsoft:master Feb 29, 2020
@jgiannuzzi jgiannuzzi deleted the sdl2-mixer-native-midi-macos branch March 2, 2020 13:56
@kevinlul kevinlul mentioned this pull request Mar 5, 2020
Closed
kevinlul added a commit to kevinlul/edopro-vcpkg-cache that referenced this pull request Mar 7, 2020
@kevinlul
[sdl2-mixer] Revert microsoft/vcpkg#10201
e9238cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgiannuzzi @GPSnoopy @msftclas @JackBoosY @strega-nil @PhoebeHui