Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ms-gsl] Update to v3.0.0 #10831

Merged
merged 3 commits into from
Apr 17, 2020
Merged

[ms-gsl] Update to v3.0.0 #10831

merged 3 commits into from
Apr 17, 2020

Conversation

Farwaykorse
Copy link
Contributor

@Farwaykorse Farwaykorse commented Apr 14, 2020 •
edited
Loading

Microsoft GSL update to release v3.0.0.

Release notes

Changes to the portfile

Add support for CMake find_package() (besides find_path()):

find_package(Microsoft.GSL CONFIG REQUIRED)

target_link_libraries(main PRIVATE Microsoft.GSL::GSL)

@Farwaykorse Farwaykorse marked this pull request as ready for review April 14, 2020 22:24
@NancyLi1013 NancyLi1013 self-assigned this Apr 15, 2020
NancyLi1013
NancyLi1013 suggested changes Apr 15, 2020
View reviewed changes
ports/ms-gsl/portfile.cmake Outdated Show resolved Hide resolved
ports/ms-gsl/portfile.cmake Outdated Show resolved Hide resolved
@Farwaykorse Farwaykorse mentioned this pull request Apr 16, 2020
Closed
@Farwaykorse Farwaykorse changed the title [ms-gsl] Update to 2019-04-13 [ms-gsl] Update to v3.0.0 Apr 16, 2020
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 17, 2020
Merged
@Farwaykorse Farwaykorse mentioned this pull request Apr 17, 2020
Closed
@ras0219-msft ras0219-msft merged commit acff7d4 into microsoft:master Apr 17, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Farwaykorse @ras0219-msft @Neumann-A @NancyLi1013