Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for FFmpeg in UWP. #1310

Merged
merged 3 commits into from
Jun 22, 2017
Merged

Conversation

khouzam
Copy link
Contributor

@khouzam khouzam commented Jun 19, 2017

This enables ffmpeg to be compiled as a UWP as well as a desktop app.

Adding support to download gas-preprocessor as an acquire_program.
Update all packages when installing msys2
Download perl and gcc for ARM assembly in ffmpeg through msys (for gas-preprocessor.pl).

Adding support to download gas-preprocessor as an acquire_program.
Update all packages for msys2
Download perl and gcc for ARM assembly in ffmpeg.
@msftclas
Copy link

@khouzam,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@bagong
Copy link
Contributor

bagong commented Jun 19, 2017

Any hope for a working static build for the windows platform? 😄 (portability)

@khouzam
Copy link
Contributor Author

khouzam commented Jun 19, 2017

I might have some time to take a look at that

@bagong
Copy link
Contributor

bagong commented Jun 19, 2017

That would be really appreciated!!! 😄 I just built an app with ffmpeg static and was surprised it didn't run, until I realized it still needed access to the "static ffmpeg dlls" ;)

@ras0219-msft
Copy link
Contributor

Thanks for the PR, @khouzam!

I pushed a few changes to your branch (bump the version number and hopefully fix the libcmt thing).

For some reason, my arm-uwp builds fail with:

:: Synchronizing package databases...
 mingw32 is up to date
 mingw64 is up to date
 msys is up to date
 there is nothing to do
=== CONFIGURING ===
GNU assembler not found, install/update gas-preprocessor

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.freenode.net.
Include the log file "config.log" produced by configure as this will help
solve the problem.

Any ideas?

@khouzam
Copy link
Contributor Author

khouzam commented Jun 20, 2017

Hi @ras0219-msft

Can you share the config.log in the ffmpeg arm build?

@khouzam
Copy link
Contributor Author

khouzam commented Jun 20, 2017

I've reproed the issue, the system is not installing gcc & perl for MSYS properly.

Reverting these lines in the ffmpeg portfile makes it run again:

        vcpkg_execute_required_process(
            COMMAND ${BASH} --noprofile --norc -c "PATH=/usr/bin:\$PATH;pacman -Sy --noconfirm --needed perl gcc"
            WORKING_DIRECTORY ${CURRENT_BUILDTREES_DIR}
            LOGNAME msys-${TARGET_TRIPLET}

@khouzam
Copy link
Contributor Author

khouzam commented Jun 20, 2017

Ok I fixed the issue. Switching from double quotes to single quotes makes bash happy again.

@ras0219-msft ras0219-msft merged commit c697b40 into microsoft:master Jun 22, 2017
@ras0219-msft
Copy link
Contributor

Thanks a ton @khouzam :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants