Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evpp] Update to version 0.6.1 #1328

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Conversation

zieckey
Copy link
Contributor

@zieckey zieckey commented Jun 21, 2017

No description provided.

@msftclas
Copy link

@zieckey,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@ras0219-msft
Copy link
Contributor

Thanks for the update PR!

I simplified the port to use vcpkg_from_github(), which also enables vcpkg install evpp --head to pull from the master branch.

I noticed some file(REMOVE) statements that were operating on non-existent directories, so I removed them. If you plan to export CMake config files in the future, please take a look at vcpkg_fixup_cmake_targets()[1] which might help quite a bit :).

[1] https://github.com/Microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_fixup_cmake_targets.cmake

@ras0219-msft ras0219-msft merged commit ff21b90 into microsoft:master Jun 22, 2017
@zieckey
Copy link
Contributor Author

zieckey commented Jun 22, 2017

@ras0219-msft Thanks for the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants