Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many ports] add GnuPG libraries #13950

Merged
merged 22 commits into from
Dec 23, 2020
Merged

[many ports] add GnuPG libraries #13950

merged 22 commits into from
Dec 23, 2020

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Oct 9, 2020 •
edited
Loading

Adds GnuPG libraries ports

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Currently tested on macOS and Linux only with gettext package installed. Windows builds fail due to missing autopoint tool, which is part of gettext. See #13518 for details.

Yes.

@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 10, 2020
@LilyWangL
Copy link
Contributor

@wrobelda Thanks for your PR. Now libgpg-error build failed with the following error:

autoreconf: Entering directory `.'
autoreconf: running: autopoint --force
Can't exec "autopoint": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 345.
autoreconf: failed to run autopoint: No such file or directory
autoreconf: autopoint is needed because this package uses Gettext

@wrobelda
Copy link
Contributor Author

wrobelda commented Oct 10, 2020 •
edited
Loading

@wrobelda Thanks for your PR. Now libgpg-error build failed with the following error:

Yes, I explained in the PR above why is this happening:

"Windows builds fail due to missing autopoint tool, which is part of gettext. See #13518 for details."

@LilyWangL LilyWangL added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Oct 13, 2020
@wrobelda
Copy link
Contributor Author

wrobelda commented Oct 13, 2020 •
edited
Loading

@LilyWangL I suppose we can release it as-is with your changes (91e71d6). I'll revisit once #13518 is addressed and autopoint made available for Windows.

@Hoikas
Copy link
Contributor

Hoikas commented Oct 15, 2020

Per the maintainer's guide:

When adding a new port, use the new manifest syntax for defining a port

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 16, 2020
@LilyWangL LilyWangL marked this pull request as ready for review October 16, 2020 06:35
@LilyWangL LilyWangL added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 16, 2020
@LilyWangL
Copy link
Contributor

@wrobelda I test features of gpgme, gpgme[qt] and gpgme[python] both build failed on Linux. Could you fix them? I found if you want install gpgme[python], you need install swig and python3-dev. But after installing them, gpgme[python] build failed with the new error.

@LilyWangL LilyWangL marked this pull request as draft October 16, 2020 08:43
@LilyWangL
Copy link
Contributor

Pinging @wrobelda for response.

@PhoebeHui PhoebeHui added requires:author-response and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Nov 16, 2020
@wrobelda
Copy link
Contributor Author

Except the patch name, others looks good for me. thanks for your contribution!

Thank you as well. Fixed the patch name, it's ready to go!

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 17, 2020
strega-nil
strega-nil reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, then I'll merge :)

ports/gpgme/CONTROL Outdated Show resolved Hide resolved
ports/libassuan/CONTROL Outdated Show resolved Hide resolved
ports/libassuan/portfile.cmake Outdated Show resolved Hide resolved
ports/libgcrypt/portfile.cmake Outdated Show resolved Hide resolved
ports/libgpg-error/portfile.cmake Outdated Show resolved Hide resolved
@PhoebeHui
Copy link
Contributor

@wrobelda, could you address the review request?

@PhoebeHui PhoebeHui removed the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2020
@wrobelda
Copy link
Contributor Author

wrobelda commented Nov 27, 2020 •
edited
Loading

@wrobelda, could you address the review request?

I am without a workstation temporarily, will address these suggestions asap. Thank you!

wrobelda and others added 5 commits December 13, 2020 14:10
@wrobelda @strega-nil
[gpgme] explicitly disable windows support
0ffbea1 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@wrobelda @strega-nil
[libassuan] explicitly disable windows support
316eef0 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@wrobelda @strega-nil
Apply suggestions from code review
05ad6c2 
Add EOF newlines

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@wrobelda
[libgpg-error] explicitly disable windows support
63e88a7
@wrobelda
Merge remote-tracking branch 'origin/master' into gpg
d093d4a
@wrobelda
Copy link
Contributor Author

@strega-nil Suggestions applied. My apologies for the delay.

PhoebeHui
PhoebeHui requested changes Dec 22, 2020
View reviewed changes
ports/gpgme/CONTROL Outdated Show resolved Hide resolved
@wrobelda @PhoebeHui
[gpgme] whitespace fixes
8cc943b 
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 22, 2020
@BillyONeal BillyONeal merged commit 4cf45e8 into microsoft:master Dec 23, 2020
@BillyONeal
Copy link
Member

Thanks a bunch!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@wrobelda
[many ports] add GnuPG libraries (microsoft#13950)
a7a3acd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas left review comments

@strega-nil strega-nil strega-nil left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wrobelda @LilyWangL @Hoikas @PhoebeHui @BillyONeal @strega-nil