-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onnxruntime] Add new port #14903
[onnxruntime] Add new port #14903
Conversation
@pash-msft |
I am working with @pash-msft to get his Github account correctly linked with his FTE microsoft.com account in the internal systems, and make the CLA Bot happy. Thank you @NancyLi1013 for proceeding with the code review for this change while we work through the processes to get all the correct GH account linkage and GH org membership settings sorted out in the systems. |
Thanks Jorgen. I followed your suggestion. The PR has now met CLA requirement. |
The failures on x64-linux:
Could you please look into this and try to fix it? |
onnxruntime:x64-uwp=fail | ||
onnxruntime:x64-windows=fail | ||
onnxruntime:x64-windows-static=fail | ||
onnxruntime:x86-windows=fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you set all triplets fail here? If not supports, we should add supports
field to vckg.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting CI errors for the above triplets, the suggested solution was to add expected failures here. If I use vcpkg_fail_port_install, how do I tell CI pipeline to ignore failure on these unsupported ARCH and Target. Thanks for your feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add supports": "windows & !x86 & !uwp & !static & !arm & !wasm32
to vcpkg.json and remove these codes in ci.baseline.txt.
Please refer to https://github.com/microsoft/vcpkg/blob/master/ports/onnxruntime-gpu/vcpkg.json#L6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to find right values here. There are only two triplets to be supported:
x64-linux
x64-windows-static-md
Could you please suggest me changes for vcpkg.json and portfile.cmake? Looks like I have to keep it the way it is. Let me know. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about x64-windows
and x64-windows-static
? Are they not supported?
x64-windows-static-md
is community triplet, which will not be tested on CI pipeline.
If so, currently this port only supports Linux. We can add supports: linux
to vcpkg.json and vcpkg_fail_port_install(ON_TARGET "windows" "osx")
to portfile.cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to support x64-windows and x64-windows-static. Currently, we don't use these builds in our application. This can be extended to support future platforms.
Our application will use x64-windows-static-md build configuration. So, we can not have vcpkg_fail_port_install(ON_TARGET "windows" "osx") in the portfile.cmake correct?
If you are OK , can we have it approved. Have addressed other feedbacks. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these triplets are currently not officially supported, we can add supports instead of adding them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We plan to add support incrementally. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these codes here.
The latest failures on linux:
|
Fixed it. Thanks |
fixed |
"name": "onnxruntime", | ||
"version-string": "1.5.3", | ||
"description": "ONNX Runtime is a cross-platform inferencing and training accelerator compatible with many popular ML/DNN frameworks, including PyTorch, TensorFlow/Keras, scikit-learn.", | ||
"homepage": "https://github.com/microsoft/onnxruntime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"homepage": "https://github.com/microsoft/onnxruntime" | |
"homepage": "https://github.com/microsoft/onnxruntime", | |
"supports:" "x64 & linux" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two triplets, x64-windows-static-md and x64-linux are supported. Don't think above works for x64-windows-static-md , correct? Once we add support of more of supported triplets, this can written as you suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it should be x64 & linux
.
onnxruntime:x64-uwp=fail | ||
onnxruntime:x64-windows=fail | ||
onnxruntime:x64-windows-static=fail | ||
onnxruntime:x86-windows=fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these triplets are currently not officially supported, we can add supports instead of adding them here.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This should be fixed now. |
@gapopu can you please take a look at pipeline failures? |
@NancyLi1013 I don't understand the reason why x64-windows-static-md is failing. I was able to get it passed in my local setup. Can you help me understand what the issue is? |
The failures on
You can get the log here https://dev.azure.com/vcpkg/public/_build/results?buildId=50349&view=artifacts&pathAsName=false&type=publishedArtifacts |
SOURCE_PATH "${SOURCE_PATH}/cmake" | ||
PREFER_NINJA | ||
OPTIONS | ||
-Donnxruntime_ENABLE_PYTHON=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onnxruntime python wheels are normally distributed through pypi. Is there a need to build it through vcpkg? If not, you may set it to OFF.
Is work still being done for this PR? |
Is there a plan to add ONNX there? |
You can open a new issue for ONNX if you would like to add it in vcpkg. |
Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us! |
Describe the pull request
Add new port for OnnxRuntime:
https://github.com/microsoft/onnxruntime
This is a new port
Only supported triplets are x86-windows-static and x86-linux-static
Yes