[openblas] update to 0.3.15 version and add dynamic arch feature #15238

xandox · 2020-12-21T16:34:43Z

Add dynamic arch feature to OpenBLAS ports

What does your PR fix? Fixes # Add new feature
Which triplets are supported/not supported? Have you updated the CI baseline? Same
Does your PR follow the maintainer guide? yes

ports/openblas/CONTROL

NancyLi1013 · 2020-12-22T02:20:44Z

@xandox

Have you tested the feature dynamic-arch?

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

xandox · 2020-12-22T11:13:27Z

@NancyLi1013 before PR I build with dynamic-arch feature for x64-linux, today I try to build for arm64-android and version 0.3.10 would not build. I also update version.

xandox · 2020-12-22T12:16:51Z

Oh, how to debug failed tests?

NancyLi1013 · 2020-12-23T06:10:39Z

For the failure on osx, there is no error log generated. I have rerun it and let's see the new test result.

For the feature test, you can test x86-windows and x64-windows.

ports/openblas/CONTROL

NancyLi1013 · 2020-12-23T06:45:42Z

The failures are like this:

/Users/vagrant/Data/buildtrees/openblas/src/7079f26fa1-32aa3694bc.clean/kernel/x86_64/srot_microk_haswell-2.c:41:14: error: always_inline function '_mm256_fmadd_ps' requires target feature 'fma', but would be inlined into function 'srot_kernel' that is compiled without support for 'fma'
        t0 = _mm256_fmadd_ps(c_256, x0, t0);
             ^
/Users/vagrant/Data/buildtrees/openblas/src/7079f26fa1-32aa3694bc.clean/kernel/x86_64/srot_microk_haswell-2.c:42:14: error: always_inline function '_mm256_fmadd_ps' requires target feature 'fma', but would be inlined into function 'srot_kernel' that is compiled without support for 'fma'
        t1 = _mm256_fmadd_ps(c_256, x1, t1);
             ^
/Users/vagrant/Data/buildtrees/openblas/src/7079f26fa1-32aa3694bc.clean/kernel/x86_64/srot_microk_haswell-2.c:43:14: error: always_inline function '_mm256_fmadd_ps' requires target feature 'fma', but would be inlined into function 'srot_kernel' that is compiled without support for 'fma'
        t2 = _mm256_fmadd_ps(c_256, x2, t2);

…ch_feature

NancyLi1013 · 2021-03-04T06:46:35Z

/azp run

azure-pipelines · 2021-03-04T06:46:49Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-03-04T08:45:03Z

The same error on x64-osx

NancyLi1013 · 2021-03-04T08:46:59Z

Related PR #14760

…ch_feature

xandox · 2021-03-04T15:29:36Z

Problem here is: openblas detects that processor (on check host) does not have FMA instructions set. And as it does not have this instructions -mfma flag does not append to compilator arguments. But openblas still use intrinsics from FMA set if processor is HASWELL and that is why error is produced.
I created issue OpenMathLib/OpenBLAS#3128 for openblas.

xandox · 2021-05-03T09:35:35Z

@martin-frbg thank you!

xandox · 2021-05-05T09:06:20Z

up

NancyLi1013 · 2021-05-07T07:44:54Z

LGTM now, thanks for your patience and contribution @xandox. Also thanks everyone here.

dan-shaw · 2021-05-18T05:55:18Z

ports/openblas/portfile.cmake

+
+if(VCPKG_TARGET_IS_OSX)
+    if("dynamic-arch" IN_LIST FEATURES)
+        set(VCPKG_LIBRARY_LINKAGE dynamic)


We generally should not change library linkage if a feature is enabled. If a feature does not support a linkage type, we should output message(FATAL_ERROR). Does the dynamic-arch feature work for other platforms? We should also output an error if this feature is enabled on platforms that are not supported.

There actually a issue not with openblas directly but in ninja.
https://gitlab.kitware.com/cmake/cmake/-/issues/16731
rsp-file contains 7001 lines of other libraries.

Can you suggest some other ways to resolve it without message(FATAL_ERROR)?

vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)

plus a message about why this is happening.

…ch_feature

NancyLi1013 · 2021-05-27T05:39:06Z

/azp run

azure-pipelines · 2021-05-27T05:39:15Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2021-07-20T09:14:36Z

@xandox
Could you please resolve the conflicts in this PR?

…ch_feature

xandox · 2021-07-20T12:31:05Z

@xandox
Could you please resolve the conflicts in this PR?

done, once again

NancyLi1013 · 2021-07-21T01:44:19Z

LGTM now, thanks for your PR. @xandox

vicroms

This LGTM once merge conflicts have been solved

…blas_dynamic_arch_feature # Conflicts: # ports/openblas/vcpkg.json # versions/baseline.json # versions/o-/openblas.json

vicroms · 2021-07-25T19:47:42Z

/azp run

azure-pipelines · 2021-07-25T19:47:52Z

Azure Pipelines successfully started running 1 pipeline(s).

Ilya Arzhannikov added 2 commits December 21, 2020 17:31

[openblas] dynamic arch feature

1c314bd

remove debug output

7785fff

JonLiu1993 assigned NancyLi1013 Dec 22, 2020

NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 22, 2020

NancyLi1013 suggested changes Dec 22, 2020

View reviewed changes

ports/openblas/CONTROL Outdated Show resolved Hide resolved

NancyLi1013 added the requires:author-response label Dec 22, 2020

xandox and others added 2 commits December 22, 2020 11:39

Update ports/openblas/CONTROL

1cdd6ad

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

update version to 0.3.13

63a3862

xandox changed the title ~~[openblas] dynamic arch feature~~ [openblas] update to 0.3.13 version and add dynamic arch feature Dec 22, 2020

xandox requested a review from NancyLi1013 December 22, 2020 11:13

Merge remote-tracking branch 'origin/master' into HEAD

2c18975

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 23, 2020

NancyLi1013 suggested changes Dec 23, 2020

View reviewed changes

ports/openblas/CONTROL Outdated Show resolved Hide resolved

xandox added 2 commits January 25, 2021 14:49

Merge remote-tracking branch 'origin/master' into openblas_dynamic_ar…

69bc258

…ch_feature

osx build

49a7e85

NancyLi1013 mentioned this pull request Mar 4, 2021

[OpenBLAS] Dynamic CPU architecture support #11623

Closed

xandox added 3 commits March 4, 2021 14:33

Merge remote-tracking branch 'origin/master' into openblas_dynamic_ar…

32e9675

…ch_feature

fix CONTROL, add FEATURES keyword to vcpkg_check_features

38fd952

x-add-version

fcf02bd

xandox closed this Mar 4, 2021

xandox requested a review from NancyLi1013 May 3, 2021 11:57

NancyLi1013 approved these changes May 7, 2021

View reviewed changes

NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 7, 2021

dan-shaw reviewed May 18, 2021

View reviewed changes

dan-shaw added the requires:author-response label May 18, 2021

NancyLi1013 removed the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021

NancyLi1013 requested a review from dan-shaw May 19, 2021 07:40

Ilya Arzhannikov added 3 commits May 26, 2021 15:58

vcpkg_check_linkage

0fb4f39

./vcpkg x-add-version openblas --overwrite-version

2f659c2

Merge remote-tracking branch 'origin/master' into openblas_dynamic_ar…

78ae86f

…ch_feature

xandox added 2 commits July 20, 2021 14:28

Merge remote-tracking branch 'origin/master' into openblas_dynamic_ar…

12b92b3

…ch_feature

./vcpkg x-add-version openblas --overwrite-version

2248b6c

NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 21, 2021

vicroms approved these changes Jul 23, 2021

View reviewed changes

NancyLi1013 added 2 commits July 22, 2021 23:12

Merge branch 'master' of https://github.com/Microsoft/vcpkg into open…

e499f57

…blas_dynamic_arch_feature # Conflicts: # ports/openblas/vcpkg.json # versions/baseline.json # versions/o-/openblas.json

Update versions/o-/openblas.json

e8d9a66

vicroms merged commit ce91faf into microsoft:master Jul 26, 2021

dg0yt mentioned this pull request Oct 27, 2021

[openblas] make openblas build on MinGW #20986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openblas] update to 0.3.15 version and add dynamic arch feature #15238

[openblas] update to 0.3.15 version and add dynamic arch feature #15238

xandox commented Dec 21, 2020

NancyLi1013 commented Dec 22, 2020

xandox commented Dec 22, 2020

xandox commented Dec 22, 2020

NancyLi1013 commented Dec 23, 2020

NancyLi1013 commented Dec 23, 2020

NancyLi1013 commented Mar 4, 2021

azure-pipelines bot commented Mar 4, 2021

NancyLi1013 commented Mar 4, 2021

NancyLi1013 commented Mar 4, 2021

xandox commented Mar 4, 2021

xandox commented May 3, 2021

xandox commented May 5, 2021

NancyLi1013 commented May 7, 2021

dan-shaw May 18, 2021

xandox May 18, 2021

ras0219 May 20, 2021

NancyLi1013 commented May 27, 2021

azure-pipelines bot commented May 27, 2021

NancyLi1013 commented Jul 20, 2021

xandox commented Jul 20, 2021

NancyLi1013 commented Jul 21, 2021

vicroms left a comment

vicroms commented Jul 25, 2021

azure-pipelines bot commented Jul 25, 2021

[openblas] update to 0.3.15 version and add dynamic arch feature #15238

[openblas] update to 0.3.15 version and add dynamic arch feature #15238

Conversation

xandox commented Dec 21, 2020

NancyLi1013 commented Dec 22, 2020

xandox commented Dec 22, 2020

xandox commented Dec 22, 2020

NancyLi1013 commented Dec 23, 2020

NancyLi1013 commented Dec 23, 2020

NancyLi1013 commented Mar 4, 2021

azure-pipelines bot commented Mar 4, 2021

NancyLi1013 commented Mar 4, 2021

NancyLi1013 commented Mar 4, 2021

xandox commented Mar 4, 2021

xandox commented May 3, 2021

xandox commented May 5, 2021

NancyLi1013 commented May 7, 2021

dan-shaw May 18, 2021

Choose a reason for hiding this comment

xandox May 18, 2021

Choose a reason for hiding this comment

ras0219 May 20, 2021

Choose a reason for hiding this comment

NancyLi1013 commented May 27, 2021

azure-pipelines bot commented May 27, 2021

NancyLi1013 commented Jul 20, 2021

xandox commented Jul 20, 2021

NancyLi1013 commented Jul 21, 2021

vicroms left a comment

Choose a reason for hiding this comment

vicroms commented Jul 25, 2021

azure-pipelines bot commented Jul 25, 2021