-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spirv-cross,spirv-headers,spirv-tools] 2021-01-15 update #15831
Conversation
Most of them are good, but I have some questions:
|
why should we delete the config files from spirv-cross? I'll check the package config files later today why is the library incorrect on linux, I didn't touch the library names at all and I don't want to force the package to generate libraries with a linuxey name if it doesn't do that on it's own (I don't want to change the library names from upstream). |
also I didn't touch glslang, I will check if spirv has an embedded dependency on glslang, but if not I'm not sure how to proceed there. I don't want to modify either package if they both generate those headers from the glsl specification xml. |
Because all cmake configuration files should be installed in share/NAME, so I guess
Becuase our triplet
Yes, glslang's issue doesn't related to your changes, I just notify it. |
51dddae
to
c0be236
Compare
@JackBoosY I have addressed the review comments, and also moved to a newer version of spirv-tools which required a newer (non released!) version of spirv-headers, I wrote the version as the date I accessed the repo. |
Waiting for merge #16904. |
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Describe the pull request
Additionally removed several no-longer-needed patches from spirv-tools.
I think that spirv-tools and spirv-cross actually will build shared libs on windows now, but I have not gone and gotten that working.