[llvm] update to 11.1.0, add features and fix issues #16232

yurybura · 2021-02-15T09:45:37Z

This PR adds more features (libc, libcxx, libunwind, etc.) and fixes issues.

Fixes #16222
Fixes #16215
Fixes #15228
Fixes #14900
Fixes #12262

PhoebeHui · 2021-02-18T07:28:57Z

@yurybura, thanks for your contribution!

Here is CI failures:
x86-windows/x64-windows/x64-windows-static, related to old issue #14900

-- Performing post-build validation

The following dlls were found in /lib or /debug/lib. Please move them to /bin or /debug/bin, respectively.

    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.asan_dynamic-x86_64.dll

The following dlls were found in /lib or /debug/lib. Please move them to /bin or /debug/bin, respectively.

    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.asan_dynamic-x86_64d.dll

Expected Debug,Dynamic crt linkage, but the following libs had invalid crt linkage:

 D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.asan-preinit-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.asan-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.asan_cxx-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.asan_dll_thunk-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.builtins-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.fuzzer-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.fuzzer_no_main-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.profile-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.stats-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.stats_client-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.ubsan_standalone-x86_64d.lib: Release,Static
    D:/packages/llvm_x64-windows/debug/lib/clang/11.0.0/lib/windows/clang_rt.ubsan_standalone_cxx-x86_64d.lib: Release,Static

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Expected Release,Dynamic crt linkage, but the following libs had invalid crt linkage:
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.asan-preinit-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.asan-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.asan_cxx-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.asan_dll_thunk-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.builtins-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.fuzzer-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.fuzzer_no_main-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.profile-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.stats-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.stats_client-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.ubsan_standalone-x86_64.lib: Release,Static
    D:/packages/llvm_x64-windows/lib/clang/11.0.0/lib/windows/clang_rt.ubsan_standalone_cxx-x86_64.lib: Release,Static

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Found 4 error(s). Please correct the portfile:
    C:\a\1\s\ports\llvm\portfile.cmake

x64-linux:

  LIBCXX_ENABLE_STATIC_ABI_LIBRARY is an experimental option

CMake Error at projects/libcxx/src/cmake_install.cmake:82 (file):
  file INSTALL cannot find
  "/mnt/vcpkg-ci/buildtrees/llvm/x64-linux-dbg/./lib/libc++.so": No such file
  or directory.
Call Stack (most recent call first):
  projects/libcxx/cmake_install.cmake:56 (include)
  projects/cmake_install.cmake:50 (include)
  cmake_install.cmake:76 (include)

x64-osx:

-- Performing post-build validation
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/llvm/cmake.
Please use the helper function `vcpkg_fixup_cmake_targets()`
The following cmake files were found outside /share/llvm. Please place cmake files in /share/llvm.

    /Users/vagrant/Data/packages/llvm_x64-osx/lib/cmake/ParallelSTL/ParallelSTLConfig.cmake
    /Users/vagrant/Data/packages/llvm_x64-osx/lib/cmake/ParallelSTL/ParallelSTLConfigVersion.cmake
    /Users/vagrant/Data/packages/llvm_x64-osx/lib/cmake/ParallelSTL/ParallelSTLTargets.cmake
    /Users/vagrant/Data/packages/llvm_x64-osx/debug/lib/cmake/ParallelSTL/ParallelSTLConfig.cmake
    /Users/vagrant/Data/packages/llvm_x64-osx/debug/lib/cmake/ParallelSTL/ParallelSTLConfigVersion.cmake
    /Users/vagrant/Data/packages/llvm_x64-osx/debug/lib/cmake/ParallelSTL/ParallelSTLTargets.cmake

The /debug/lib/cmake folder should be merged with /lib/cmake into /share/llvm
Found 3 error(s). Please correct the portfile:
    /Volumes/data/work/1/s/ports/llvm/portfile.cmake
-- Performing post-build validation done
Error: Building package llvm:x64-osx failed with: POST_BUILD_CHECKS_FAILED

yurybura · 2021-02-19T13:46:52Z

Dear @PhoebeHui, thanks for the comment. I'll let you know when I fix it.

ports/llvm/portfile.cmake

…-update

yurybura · 2021-03-16T07:08:22Z

Dear @PhoebeHui, please check this PR. All failures have been fixed.

yurybura · 2021-03-31T06:20:03Z

Dear @PhoebeHui @ras0219-msft
please check this PR. Newer version is almost done, I want to start a new PR for 12.0.0.
Thanks!

PhoebeHui

LGTM, @vicroms, could you help review and merge this PR?

ras0219-msft

I'd also like to get this reviewed by @alexreinking, since I know he's a consumer of llvm (via halide)

ports/llvm/CONTROL

alexreinking · 2021-04-02T22:42:53Z

Going to try compiling Halide against this locally. Will take a few hours.

alexreinking

As far as Halide is concerned, this seems fine. It built successfully for me on x64-windows (release only) and upstream Halide builds successfully against it.

ports/llvm/CONTROL

ports/llvm/portfile.cmake

alexreinking

I'd prefer to see modern CMake in custom usage files. I made one comment per directory command, but there are multiple instances.

ports/llvm/clang_usage

ports/llvm/llvm_usage

yurybura · 2021-04-06T10:20:14Z

@alexreinking @ras0219-msft
Thank you for review!
Please have a look one more time.

PhoebeHui · 2021-04-08T07:04:02Z

@strega-nil, could you please help review and merge this PR?

strega-nil

these are the things I see; the biggest thing you need to do is figure out the usage issue

ports/llvm/llvm_usage

ports/llvm/portfile.cmake

ports/llvm/clang_usage

yurybura added 4 commits February 15, 2021 18:41

fix issue #16215

e00037f

add more projects and fix issue #16222

87cb4a1

add version

c6732e8

exclude libc from default projects

e30adfd

PhoebeHui assigned JackBoosY and PhoebeHui and unassigned JackBoosY Feb 18, 2021

PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels Feb 18, 2021

invertego reviewed Feb 28, 2021

View reviewed changes

ports/llvm/portfile.cmake Outdated Show resolved Hide resolved

yurybura added 13 commits March 7, 2021 15:28

remove libc, add fland to default projects

5882cef

Merge branch 'master' of https://github.com/microsoft/vcpkg into llvm…

f6438c0

…-update

update to v11.1.0

e98d7b0

fix compiler-rt install path

015a0da

fix SHA for version 11.1.0

126906b

fix libc++ install

afc307c

re-fix libc++ install

0cd4443

fix pstl install

72c2557

fix flang's license file name

96eee07

install tools in tools/llvm, fix file names

b096a85

revert bin directory for libraries

439433a

don't create clang sub-directory in llvm/tools

9380b46

overwrite version

ced92f9

yurybura marked this pull request as ready for review March 16, 2021 07:05

yurybura mentioned this pull request Mar 18, 2021

[llvm] build failure #16759

Closed

PhoebeHui added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Mar 18, 2021

PhoebeHui requested a review from ras0219-msft March 18, 2021 11:22

overwrite version

3722ef6

PhoebeHui approved these changes Mar 31, 2021

View reviewed changes

PhoebeHui assigned vicroms Apr 1, 2021

ras0219-msft reviewed Apr 2, 2021

View reviewed changes

ports/llvm/CONTROL Outdated Show resolved Hide resolved

alexreinking approved these changes Apr 3, 2021

View reviewed changes

ports/llvm/CONTROL Outdated Show resolved Hide resolved

ports/llvm/portfile.cmake Show resolved Hide resolved

yurybura added 3 commits April 3, 2021 20:18

convert manifest to json

d4a8294

install usage files

6fe189e

overwrite version

ed8705e

yurybura mentioned this pull request Apr 4, 2021

[llvm] llvm and clang do not add themselves into the include path #12262

Closed

alexreinking reviewed Apr 4, 2021

View reviewed changes

ports/llvm/clang_usage Outdated Show resolved Hide resolved

ports/llvm/llvm_usage Show resolved Hide resolved

ports/llvm/llvm_usage Outdated Show resolved Hide resolved

ports/llvm/llvm_usage Outdated Show resolved Hide resolved

JackBoosY linked an issue Apr 5, 2021 that may be closed by this pull request

[llvm:x64-windows] build failure #16894

Closed

PhoebeHui added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 6, 2021

yurybura added 2 commits April 6, 2021 13:06

remove feature default-projects

d9ce53b

modernize CMake in usage files

bebe840

overwrite version

777d01c

PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 7, 2021

PhoebeHui requested a review from ras0219-msft April 7, 2021 00:35

strega-nil suggested changes Apr 8, 2021

View reviewed changes

ports/llvm/llvm_usage Outdated Show resolved Hide resolved

ports/llvm/portfile.cmake Show resolved Hide resolved

ports/llvm/clang_usage Outdated Show resolved Hide resolved

yurybura added 2 commits April 9, 2021 13:05

update ordering

52aa86d

override version

3c31bdd

PhoebeHui requested a review from strega-nil April 12, 2021 01:24

strega-nil approved these changes Apr 13, 2021

View reviewed changes

strega-nil merged commit 40449ff into microsoft:master Apr 13, 2021

yurybura deleted the llvm-update branch April 14, 2021 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[llvm] update to 11.1.0, add features and fix issues #16232

[llvm] update to 11.1.0, add features and fix issues #16232

yurybura commented Feb 15, 2021 •

edited

Loading

PhoebeHui commented Feb 18, 2021 •

edited

Loading

yurybura commented Feb 19, 2021

yurybura commented Mar 16, 2021

yurybura commented Mar 31, 2021

PhoebeHui left a comment

ras0219-msft left a comment

alexreinking commented Apr 2, 2021

alexreinking left a comment

alexreinking left a comment

yurybura commented Apr 6, 2021

PhoebeHui commented Apr 8, 2021

strega-nil left a comment

[llvm] update to 11.1.0, add features and fix issues #16232

[llvm] update to 11.1.0, add features and fix issues #16232

Conversation

yurybura commented Feb 15, 2021 • edited Loading

PhoebeHui commented Feb 18, 2021 • edited Loading

yurybura commented Feb 19, 2021

yurybura commented Mar 16, 2021

yurybura commented Mar 31, 2021

PhoebeHui left a comment

Choose a reason for hiding this comment

ras0219-msft left a comment

Choose a reason for hiding this comment

alexreinking commented Apr 2, 2021

alexreinking left a comment

Choose a reason for hiding this comment

alexreinking left a comment

Choose a reason for hiding this comment

yurybura commented Apr 6, 2021

PhoebeHui commented Apr 8, 2021

strega-nil left a comment

Choose a reason for hiding this comment

yurybura commented Feb 15, 2021 •

edited

Loading

PhoebeHui commented Feb 18, 2021 •

edited

Loading