-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Seal] Add new feature cxx14 #16886
[Seal] Add new feature cxx14 #16886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add
Port-Version: 1
after theVersion: 3.6.2
line. - Please run
.\vcpkg.exe x-add-version seal
to update the json file of seal.
@WeiDaiWD
If you haven't executed the '. \vcpkg x-add-version {port name}' on the current branch, you need to use it after your modification is completed and submitted. So, for this PR, you need to execute |
Thanks for the help! Hope I do it correctly this time. |
osgearth:x64-linux failure is a CI issue, it will be fixed by PR #16904. |
Describe the pull request
What does your PR fix? Fixes #
Added a new feature to SEAL, "cxx14", to build SEAL in C++14, which is disabled by default.
Which triplets are supported/not supported? Have you updated the CI baseline?
Tested x64-windows-static, x64-windows-static-md, x64-linux, x64-osx.
x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.
No change to the CI baseline.
Does your PR follow the maintainer guide?
Yes