Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seal] Add new feature cxx14 #16886

Closed
wants to merge 4 commits into from
Closed

Conversation

WeiDaiWD
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes #
    Added a new feature to SEAL, "cxx14", to build SEAL in C++14, which is disabled by default.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Tested x64-windows-static, x64-windows-static-md, x64-linux, x64-osx.
    x64-windows/x86-windows are not supported as the library only supports static linkage in Windows.
    No change to the CI baseline.

  • Does your PR follow the maintainer guide?
    Yes

@Cheney-W Cheney-W changed the title Seal cxx14 [Seal] Add new feature cxx14 Mar 26, 2021
@Cheney-W Cheney-W self-assigned this Mar 26, 2021
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 26, 2021
Copy link
Contributor

@Cheney-W Cheney-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add Port-Version: 1 after the Version: 3.6.2 line.
  2. Please run .\vcpkg.exe x-add-version seal to update the json file of seal.

@Cheney-W
Copy link
Contributor

@WeiDaiWD
Thanks for your so quick response. About port's json file, each of your commit changes will modify its git tree value, which means you need to update json file after you have done all the changes and executed the git commit -m "XXX" command. The specific sequence is as follows:

Git checkout -b "xxx"
Modify the local files
Git diff
Git add .
Git commit -m "comments description"
.\vcpkg x-add-version {Port name}
Git add .
Git commit -m "comments description"
git push

If you haven't executed the '. \vcpkg x-add-version {port name}' on the current branch, you need to use it after your modification is completed and submitted.
If you have executed this command on the current branch, you need to execute the following command when you need to update the json file:
.\vcpkg.exe x-add-version {port name} --overwrite-version

So, for this PR, you need to execute .\vcpkg.exe x-add-version {port name} --overwrite-version again.

@WeiDaiWD
Copy link
Contributor Author

Thanks for the help! Hope I do it correctly this time.

@Cheney-W
Copy link
Contributor

Cheney-W commented Mar 26, 2021

osgearth:x64-linux failure is a CI issue, it will be fixed by PR #16904.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 26, 2021
@PhoebeHui PhoebeHui added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Mar 29, 2021
@WeiDaiWD WeiDaiWD closed this Mar 30, 2021
@WeiDaiWD WeiDaiWD deleted the seal_cxx14 branch June 15, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants