Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[armadillo]update to 10.6.2 #19648

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Conversation

JonLiu1993
Copy link
Member

Fix #19471

Update armadillo to the latest version 10.6.2

Note: no feature need to tested

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Aug 19, 2021
@JonLiu1993 JonLiu1993 marked this pull request as ready for review August 20, 2021 06:17
@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 25, 2021
@kjohnsen
Copy link

kjohnsen commented Aug 26, 2021

When I try to build my project (ldsCtrlEst) using this branch of vcpkg, I get the following error:
ninja: error: '../vcpkg/packages/armadillo_x64-windows/lib/openblas.lib', needed by 'ldsCtrlEst.lib', missing and no known rule to make it

I copied and pasted openblas.lib in there, and when building again the same thing happened, but looking for lapack.lib as well in the armadillo folder

@NancyLi1013 NancyLi1013 removed the info:reviewed Pull Request changes follow basic guidelines label Aug 27, 2021
@NancyLi1013
Copy link
Contributor

Thanks for your feedback @kjohnsen. We'll check this on our local.

@JonLiu1993 JonLiu1993 marked this pull request as draft September 7, 2021 06:17
@JonLiu1993
Copy link
Member Author

@kjohnsen ,I tested the usage of armadillo locally and the test was successful. If you have a usage problem, you can reopen an issue and we will resolve it for you as soon as possible

@JonLiu1993 JonLiu1993 marked this pull request as ready for review September 13, 2021 11:12
Comment on lines -25 to -26
-DCMAKE_DISABLE_FIND_PACKAGE_ACML=ON
-DCMAKE_DISABLE_FIND_PACKAGE_ACMLMP=ON
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options are not used in the latest version and cannot be found in the source

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 14, 2021
@BillyONeal BillyONeal merged commit 18860a0 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

Thanks for the version update!

@JonLiu1993 JonLiu1993 deleted the dev/Jon/armadillo branch September 14, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Armadillo ]update to >=10.5.2
5 participants