Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libssh/libressl] update to the latest version #20067

Merged

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Sep 9, 2021

Fix #19855 #19857

Update port libssh、libressl to the latest version

All feature are tested successfully in the latest version:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 9, 2021
This was linked to issues Sep 9, 2021
@JonLiu1993 JonLiu1993 changed the title [libssh/libssh2/libssh2] update to the latest version [libssh/libssh2/libressh] update to the latest version Sep 9, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/libressl/portfile.cmake
  • ports/libssh/portfile.cmake
  • ports/libssh2/portfile.cmake

@JonLiu1993 JonLiu1993 marked this pull request as ready for review September 18, 2021 01:53
@JonLiu1993 JonLiu1993 changed the title [libssh/libssh2/libressh] update to the latest version [libssh/libssh2/libressl] update to the latest version Sep 18, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 47d2378c8181ece05ffc51acd2ed60d97e3c9a64 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libssh2.json b/versions/l-/libssh2.json
index c6cb8a7..3dca2e5 100644
--- a/versions/l-/libssh2.json
+++ b/versions/l-/libssh2.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "c4f9e409dfb94f778bc3513c1804f46b3df6aeff",
-      "version": "1.10.0",
-      "port-version": 0
-    },
     {
       "git-tree": "d448a6d5c97053355abbfa84171fcc7624dcd509",
       "version-string": "1.9.0",

@JonLiu1993 JonLiu1993 changed the title [libssh/libssh2/libressl] update to the latest version [libssh/libressl] update to the latest version Sep 27, 2021
ports/libressl/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 27, 2021
@BillyONeal
Copy link
Member

I manually tested libssh and libressl before merging this as libressl at least is disabled in CI

@BillyONeal BillyONeal merged commit ee0584f into microsoft:master Sep 28, 2021
@BillyONeal
Copy link
Member

Thanks for the help!

@JonLiu1993 JonLiu1993 deleted the dev/Jon/libssh-libssh2/libressl branch September 28, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LibreSSL] update to 3.3.4 [libssh] update to 0.9.6
4 participants