Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lv2] Fix installation of headers to legacy paths #20102

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

DomClark
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    LV2 changed the formatting of its wscript file when it updated to 1.18.2, breaking a regular expression in this port. As a result, most header files were no longer additionally installed to their legacy locations. This PR fixes that regular expression.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change to supported triplets. CI baseline not updated.

  • Does your PR follow the maintainer guide?

    I believe so.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@DomClark DomClark marked this pull request as ready for review September 10, 2021 17:03
@PhoebeHui PhoebeHui added category:port-update The issue is with a library, which is requesting update new revision category:port-bug The issue is with a library, which is something the port should already support and removed category:port-update The issue is with a library, which is requesting update new revision labels Sep 13, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DomClark, thanks for the fix!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2021
@BillyONeal BillyONeal merged commit 88e6278 into microsoft:master Sep 14, 2021
@DomClark DomClark deleted the fix-old-lv2-headers branch September 14, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants