[fbgemm] fix find_package #20111
Merged
[fbgemm] fix find_package #20111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install internal header for pytorch
luncliff
changed the title
19 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
So... Dropping GPU feature for this PR. It's too complicated for me :( |
* The source requires ATen and some other libraries ...
luncliff
changed the title
JackBoosY
added
the
category:port-bug
JackBoosY
approved these changes
Sep 13, 2021
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Update portfile to use
vcpkg-cmake,vcpkg-cmake-configInstall some private headers
The file was required for #17199
find_package
Make CMake
find_packagework correctly.find_package(fbgemmLibrary CONFIG)Support GPU featureThe project contains sources that use CUDA. Trying to build/install it.Which triplets are supported/not supported? Have you updated the CI baseline?
All supported triplets
Does your PR follow the maintainer guide?
Yes.