Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] ci.baseline.txt updates for 2021-09-13 #20144

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

BillyONeal
Copy link
Member

Most recent CI build: https://dev.azure.com/vcpkg/public/_build/results?buildId=59428

REGRESSION: poppler:arm64-windows. If expected, add poppler:arm64-windows=fail to .\scripts\ci.baseline.txt.
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-windows (.\scripts\ci.baseline.txt)

poppler depends on fontconfig, so this isn't actually a regression.

PASSING, REMOVE FROM FAIL LIST: libfreenect2:x64-linux

Most recent CI build: https://dev.azure.com/vcpkg/public/_build/results?buildId=59428

REGRESSION: poppler:arm64-windows. If expected, add poppler:arm64-windows=fail to .\scripts\ci.baseline.txt.
PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-windows (.\scripts\ci.baseline.txt)

poppler depends on fontconfig, so this isn't actually a regression.

PASSING, REMOVE FROM FAIL LIST: libfreenect2:x64-linux
@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Sep 14, 2021
@autoantwort
Copy link
Contributor

PASSING, REMOVE FROM FAIL LIST: fontconfig:arm64-windows (.\scripts\ci.baseline.txt)

Is something like this also done for ports that are excluded by support expressions?

@PhoebeHui PhoebeHui self-assigned this Sep 14, 2021
@BillyONeal
Copy link
Member Author

Is something like this also done for ports that are excluded by support expressions?

No. This is one of the reasons support expressions need to be related to what upstream says, and why changes due to infrastructure are done in ci.baseline.txt rather than supports.

@autoantwort
Copy link
Contributor

Yeah I only asked because I have seen support expressions like windows & !windows but the package build without an error on windows (there are some other examples in #20053). So it would have been cool if the ci reported that the support expression is to restrictive.

@BillyONeal BillyONeal merged commit 0209a27 into microsoft:master Sep 14, 2021
@BillyONeal BillyONeal deleted the ci-baseline-fixes branch September 14, 2021 23:02
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 14, 2021
[vcpkg] ci.baseline.txt updates for 2021-09-13 (microsoft#20144)
@cenit
Copy link
Contributor

cenit commented Sep 15, 2021

windows & !windows was for directx legacy port? it was done to avoid building in CI and to express its legacy nature

@autoantwort
Copy link
Contributor

Yes. But we can't do that in the future with microsoft/vcpkg-tool#184. If one want to express deprecation we should introduce a deprecated field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants