Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-crt-cpp/aws-sdk-cpp] Disable parallel configure #20189

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[aws-crt-cpp/aws-sdk-cpp] Disable parallel configure #20189

merged 1 commit into from
Sep 16, 2021

Conversation

PhoebeHui
Copy link
Contributor

Fixes #20167

aws-crt-cpp/aws-sdk-cpp configure Config.h to source directory, it cause the failures in parellel configure, so disable the parellel configure.

See https://github.com/awslabs/aws-crt-cpp/blob/main/CMakeLists.txt#L87

CMake Error at CMakeLists.txt:87 (configure_file):
configure_file attempted to configure a file:
C:/Users/xanat/Documents/Files/Projects/system_monitor/third-party/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-ba58d2be12.clean/include/aws/crt/Config.h
into a source directory.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 16, 2021
@PhoebeHui
Copy link
Contributor Author

cc @camarois

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 16, 2021
@BillyONeal BillyONeal merged commit 0aa1422 into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Member

Thanks for the fix!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/aws-crt-cpp branch September 26, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-sdk-cpp build failure
3 participants
@PhoebeHui @BillyONeal @NancyLi1013