Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] Fix targets for aws-sdk-cpp components #20222

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

camarois
Copy link

@camarois camarois commented Sep 17, 2021

After further testing/investigation with the port update, find_package(aws-cpp-sdk-*) fails because the package is nested in aws-sdk-cpp folder.

I suggest building all components at once through BUILD_ONLY and fix targets so that they are not nested in the aws-sdk-cpp folder. find_package works as intended afterwards.

Also, s2n is missing release targets.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/aws-sdk-cpp/portfile.cmake
  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake

@camarois camarois marked this pull request as draft September 17, 2021 04:04
@NancyLi1013 NancyLi1013 changed the title Fix targets for aws-sdk-cpp components [aws-sdk-cpp] Fix targets for aws-sdk-cpp components Sep 17, 2021
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 17, 2021
@camarois camarois force-pushed the aws-sdk-cpp-fix-targets branch from b72b8ef to 83e5b5f Compare September 17, 2021 13:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/s2n.json b/versions/s-/s2n.json
index 61cb9ac..95229e7 100644
--- a/versions/s-/s2n.json
+++ b/versions/s-/s2n.json
@@ -11,4 +11,4 @@
       "port-version": 0
     }
   ]
-}
\ No newline at end of file
+}

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/aws-sdk-cpp/portfile.cmake
  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/s2n/portfile.cmake

@camarois camarois force-pushed the aws-sdk-cpp-fix-targets branch from 83e5b5f to 4272d3b Compare September 17, 2021 13:29
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/aws-sdk-cpp/portfile.cmake
  • ports/ffnvcodec/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/s2n/portfile.cmake

@camarois camarois marked this pull request as ready for review September 17, 2021 13:39
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2021
@BillyONeal BillyONeal merged commit 2d07df5 into microsoft:master Sep 20, 2021
@BillyONeal
Copy link
Member

Thanks for the fixes!

@camarois camarois deleted the aws-sdk-cpp-fix-targets branch October 19, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants