Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gsl] Update to 2.7 #20268

Merged
merged 4 commits into from
Sep 22, 2021
Merged

[gsl] Update to 2.7 #20268

merged 4 commits into from
Sep 22, 2021

Conversation

misirlou-tg
Copy link
Contributor

Update gsl to version 2.7

  • What does your PR fix?

    Fixes [gsl] update to 2.7 #20256

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gsl/portfile.cmake

These were the github-actions bot recommendations
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 22, 2021
@JonLiu1993 JonLiu1993 mentioned this pull request Sep 22, 2021
ports/gsl/portfile.cmake Outdated Show resolved Hide resolved
ports/gsl/portfile.cmake Outdated Show resolved Hide resolved
ports/gsl/portfile.cmake Outdated Show resolved Hide resolved
ports/gsl/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 22, 2021
@strega-nil-ms strega-nil-ms merged commit 79e8d1d into microsoft:master Sep 22, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @misirlou-tg !

@misirlou-tg misirlou-tg deleted the update-gsl branch September 22, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gsl] update to 2.7
3 participants