Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scottt-debugbreak] New port #20276

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

misirlou-tg
Copy link
Contributor

Adding port debugbreak

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@misirlou-tg misirlou-tg changed the title Add port debugbreak [debugbreak] New port Sep 22, 2021
@PhoebeHui PhoebeHui self-assigned this Sep 22, 2021
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 22, 2021
@PhoebeHui
Copy link
Contributor

There is also a library named rpms/debugbreak, in order to avoid the confuse from users, I suggest to rename the port to scottt-debugbreak.

@misirlou-tg misirlou-tg changed the title [debugbreak] New port [scottt-debugbreak] New port Sep 22, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 23, 2021
@BillyONeal BillyONeal merged commit 127ccb3 into microsoft:master Sep 24, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

@misirlou-tg misirlou-tg deleted the add-debugbreak branch September 24, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] <debugbreak>
3 participants