Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCV3] fix build with latest protobuf #20301

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Sep 23, 2021

OpenCV 3 is skipped in CI because incompatible with OpenCV 4, so this regression was not catched in #20208

@JonLiu1993 JonLiu1993 self-assigned this Sep 24, 2021
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 24, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2021
@BillyONeal
Copy link
Member

OpenCV 3 is skipped in CI because incompatible with OpenCV 4, so this regression was not catched in #20208

If you have better ideas on how to fix that... :(

Thanks for the bugfix!

@BillyONeal BillyONeal merged commit 6a398a2 into microsoft:master Sep 24, 2021
@cenit
Copy link
Contributor Author

cenit commented Sep 24, 2021

OpenCV 3 is skipped in CI because incompatible with OpenCV 4, so this regression was not catched in #20208

If you have better ideas on how to fix that... :(

Thanks for the bugfix!

i can try to work on installed folders and make all of them (ocv2/3/4) simultaneously compatible. Let me see if i can do that in a reasonable timeframe

@cenit cenit deleted the dev/cenit/pbocv3 branch September 24, 2021 19:38
@cenit
Copy link
Contributor Author

cenit commented Sep 24, 2021

also because opencv 5 is not so far away ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants