Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbdl-orb] Update port to version 3.1.2 #20305

Merged
merged 13 commits into from
Sep 30, 2021
Merged

[rbdl-orb] Update port to version 3.1.2 #20305

merged 13 commits into from
Sep 30, 2021

Conversation

ju6ge
Copy link
Contributor

@ju6ge ju6ge commented Sep 23, 2021

This PR, updates the rbdl-orb port to version 3.1.2.

What is new:

  • adds FindRBDL.cmake files
  • updates to the URDF Parser library

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9d892ff9270f2d2fe3b8e490471f0a7dfa78981e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index 8fcddc3..f972710 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "eb1ea9e4a252a9a1286ba72a8b1594da392e1533",
+      "git-tree": "d47e83ceec5a9f75cd0fef6519851f68e6b8d15a",
       "version": "3.1.2",
       "port-version": 2
     },

@JonLiu1993 JonLiu1993 self-assigned this Sep 24, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 24, 2021
@JonLiu1993 JonLiu1993 changed the title Update rbdl-orb port to rbdl-orb version 3.1.2 [rbdl-orb] Update port to version 3.1.2 Sep 24, 2021
ports/rbdl-orb/vcpkg.json Outdated Show resolved Hide resolved
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9d892ff9270f2d2fe3b8e490471f0a7dfa78981e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 94a0b87..9523226 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5694,7 +5694,7 @@
     },
     "rbdl-orb": {
       "baseline": "3.1.2",
-      "port-version": 2
+      "port-version": 0
     },
     "re2": {
       "baseline": "2020-10-01",
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index f972710..5924cad 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "d47e83ceec5a9f75cd0fef6519851f68e6b8d15a",
+      "git-tree": "90809c81f39dd26dafc1a57d44bf72a8031163a5",
       "version": "3.1.2",
-      "port-version": 2
+      "port-version": 0
     },
     {
       "git-tree": "5850c6901f4123803184bfe9b6e587af9350331a",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9d892ff9270f2d2fe3b8e490471f0a7dfa78981e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index 6927010..5924cad 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -5,11 +5,6 @@
       "version": "3.1.2",
       "port-version": 0
     },
-    {
-      "git-tree": "d47e83ceec5a9f75cd0fef6519851f68e6b8d15a",
-      "version": "3.1.2",
-      "port-version": 2
-    },
     {
       "git-tree": "5850c6901f4123803184bfe9b6e587af9350331a",
       "version": "3.0.0",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 042e1db92d115819bba6bffd681a174543111139 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index aa2e62c..8afedd9 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -5,11 +5,6 @@
       "version": "3.1.2",
       "port-version": 0
     },
-    {
-      "git-tree": "d47e83ceec5a9f75cd0fef6519851f68e6b8d15a",
-      "version": "3.1.2",
-      "port-version": 2
-    },
     {
       "git-tree": "5850c6901f4123803184bfe9b6e587af9350331a",
       "version": "3.0.0",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 042e1db92d115819bba6bffd681a174543111139 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index c698b59..b9a6133 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -5,11 +5,6 @@
       "version": "3.1.2",
       "port-version": 0
     },
-    {
-      "git-tree": "d47e83ceec5a9f75cd0fef6519851f68e6b8d15a",
-      "version": "3.1.2",
-      "port-version": 2
-    },
     {
       "git-tree": "5850c6901f4123803184bfe9b6e587af9350331a",
       "version": "3.0.0",

versions/r-/rbdl-orb.json Outdated Show resolved Hide resolved
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 042e1db92d115819bba6bffd681a174543111139 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/rbdl-orb.json b/versions/r-/rbdl-orb.json
index a903f82..b9a6133 100644
--- a/versions/r-/rbdl-orb.json
+++ b/versions/r-/rbdl-orb.json
@@ -5,7 +5,6 @@
       "version": "3.1.2",
       "port-version": 0
     },
-    {
     {
       "git-tree": "5850c6901f4123803184bfe9b6e587af9350331a",
       "version": "3.0.0",

"version": "3.1.2",
"port-version": 0
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happened here. The way I normally fix this is something like:

git fetch origin #assuming that microsoft/vcpkg is called origin
git merge origin/master
git checkout origin/master -- versions # this removes all edits to the version database
vcpkg x-add-version rbdl-orb
git commit -am "Update version database"
git push

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has extra '{' here.☺

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no permission to push the changes to this PR, @ju6ge, could you fix this issue?

Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick fix!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 30, 2021
@BillyONeal BillyONeal merged commit dd991ef into microsoft:master Sep 30, 2021
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants