[openal-soft] Remove removing macro in dynamic triplets #20310
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/openal-soft/portfile.cmake
PhoebeHui
added
info:internal
BillyONeal
removed
the
info:reviewed
|
Dropping reviewed: this is ready to land as far as I'm concerned but I would like @DanielGibson and/or @HarrievG to confirm that their bug is actually fixed before merging. |
|
checking dhewm3's dedicated build with VCPKG/CMAKE right now. |
| @@ -80,7 +80,10 @@ foreach(HEADER al.h alc.h) | |||
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | |||
| string(REPLACE "defined(AL_LIBTYPE_STATIC)" "1" AL_H "${AL_H}") | |||
| else() | |||
There was a problem hiding this comment.
Yes, the empty else() is to indicate that we didn't forget and it is intentional.
|
Fix Confirmed (x64-windows) |
|
As the issue reporters reported that this fixes it, landed. |
Add workaround suggested by Robert in #18098