Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fftw3] Update to 3.3.10 #20353

Merged
merged 4 commits into from
Sep 28, 2021
Merged

[fftw3] Update to 3.3.10 #20353

merged 4 commits into from
Sep 28, 2021

Conversation

chausner
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Updates fft3 to 3.3.10

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    As before, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@PhoebeHui PhoebeHui self-assigned this Sep 26, 2021
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 26, 2021
@BillyONeal BillyONeal merged commit d9a3542 into microsoft:master Sep 28, 2021
@BillyONeal
Copy link
Member

Thanks for the update!

URLS "http://www.fftw.org/fftw-3.3.9.tar.gz"
FILENAME "fftw-3.3.9.tar.gz"
URLS "http://www.fftw.org/fftw-3.3.10.tar.gz"
FILENAME "fftw-3.3.10.tar.gz"
SHA512 52ebc2a33063a41fd478f6ea2acbf3b511867f736591d273dd57f9dfca5d3e0b0c73157921b3a36f1a7cfd741a8a6bde0fd80de578040ae730ea168b5ba466cf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, forgot to update the sha...

./vcpkg install fftw3
Computing installation plan...
The following packages will be built and installed:
    fftw3[core]:x64-windows -> 3.3.10
Detecting compiler hash for triplet x64-windows...
Restored 0 packages from D:\Users\oracl\AppData\Local\vcpkg\archives in 216.6 us. Use --debug to see more details.
Starting package 1/1: fftw3:x64-windows
Building package fftw3[core]:x64-windows...
-- Downloading http://www.fftw.org/fftw-3.3.10.tar.gz -> fftw-3.3.10.tar.gz...
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'manifests' = off
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Downloading http://www.fftw.org/fftw-3.3.10.tar.gz
Error: Failed to download from mirror set:
File does not have the expected hash:
             url : [ http://www.fftw.org/fftw-3.3.10.tar.gz ]
       File path : [ D:\Tools\vcpkg\downloads\fftw-3.3.10.tar.gz.3216.part ]
   Expected hash : [ 52ebc2a33063a41fd478f6ea2acbf3b511867f736591d273dd57f9dfca5d3e0b0c73157921b3a36f1a7cfd741a8a6bde0fd80de578040ae730ea168b5ba466cf ]
     Actual hash : [ 2d34b5ccac7b08740dbdacc6ebe451d8a34cf9d9bfec85a5e776e87adf94abfd803c222412d8e10fbaa4ed46f504aa87180396af1b108666cde4314a55610b40 ]


[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(626)
[DEBUG] Exiting after 1.974 s us (1806352 us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:83 (message):

      Failed to download file with error: 1
      If you use a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. You are using Fiddler. Currently a bug (https://github.com/microsoft/vcpkg/issues/17752)
         will set HTTPS_PROXY to `https://fiddler_address:port` which lead to problem 1 above.
         Workaround is open Windows 10 Settings App, and search for Proxy Configuration page,
         Change `http=address:port;https=address:port` to `address`, and fill the port number.

      3. You proxy's remote server is out of service.

      In future vcpkg releases, if you are using Windows, you no longer need to set
      HTTP(S)_PROXY environment variables. Vcpkg will simply apply Windows IE Proxy
      Settings set by your proxy software. See (https://github.com/microsoft/vcpkg-tool/pull/49)
      and (https://github.com/microsoft/vcpkg-tool/pull/77)

      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:274 (z_vcpkg_download_distfile_show_proxy_and_fail)
  ports/fftw3/portfile.cmake:1 (vcpkg_download_distfile)
  scripts/ports.cmake:141 (include)


Error: Building package fftw3:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: fftw3:x64-windows
  Vcpkg version: 2021-09-10-2059ef11aa6067e6f59b0d939c5d17e3c5c47d3e

Additionally, attach any relevant sections from the log files above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oracleoftroy, thanks for pointing out this! I will submit a PR to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are failing for me as well because of this. The MD5 sum matches the one listed on https://fftw.org/download.html so it seems the problem is in vcpkg.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did CI fail to catch this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants