[tree.hh] Add new port. #20427
Merged
[tree.hh] Add new port. #20427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
PhoebeHui
added
the
category:new-port
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PhoebeHui
requested changes
Sep 30, 2021
ports/treehh/portfile.cmake
Outdated
Comment on lines
9
to
10
| file(INSTALL ${SOURCE_PATH}/src/tree.hh DESTINATION ${CURRENT_PACKAGES_DIR}/include) | ||
| file(INSTALL ${SOURCE_PATH}/src/tree.hh DESTINATION ${CURRENT_PACKAGES_DIR}/share/treehh RENAME copyright) |
There was a problem hiding this comment.
Suggested change
| file(INSTALL ${SOURCE_PATH}/src/tree.hh DESTINATION ${CURRENT_PACKAGES_DIR}/include) | |
| file(INSTALL ${SOURCE_PATH}/src/tree.hh DESTINATION ${CURRENT_PACKAGES_DIR}/share/treehh RENAME copyright) | |
| file(INSTALL "${SOURCE_PATH}/src/tree.hh" DESTINATION "${CURRENT_PACKAGES_DIR}/include") | |
| file(INSTALL "${SOURCE_PATH}/src/tree.hh" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright) |
There was a problem hiding this comment.
@Hconk, Could you minimize the copyright? please only include the license information instead.
@BillyONeal, do we need install tree.hh into a subidrectory like treehh/tree.hh?
There was a problem hiding this comment.
Okay, move tree.hh to treehh/tree.hh , and minimize the copyright.
PhoebeHui
approved these changes
Sep 30, 2021
|
Thanks for the new port! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new port tree.hh
An STL-like C++ header-only tree library
What does your PR fix?
[New Port Request] tree.hh #19799
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/