[vcpkg-scripts] Use pkgconf in vcpkg pkgconfig get modules #20527
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ports/vcpkg-pkgconfig-get-modules/x_vcpkg_pkgconfig_get_modules.cmake
Outdated
Show resolved
Hide resolved
i wanted to apply it to other stuff too but the script audit is kind of slow for the make and fixup pkgconfig stuff. so i started here. |
JackBoosY
added
the
category:tool-update
…pkgconf_in_vcpkg_pkgconfig_get_modules
PhoebeHui
added
the
requires:vcpkg-team-review
…s.cmake Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
…pkg_pkgconfig_get_modules
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 431d3810aa9241aed49b14367be417f225d2af5e -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/v-/vcpkg-pkgconfig-get-modules.json b/versions/v-/vcpkg-pkgconfig-get-modules.json
index 5a8b351..5bda670 100644
--- a/versions/v-/vcpkg-pkgconfig-get-modules.json
+++ b/versions/v-/vcpkg-pkgconfig-get-modules.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e34705e29ded3234cf8c21d7802c02a855a01ecb",
+ "git-tree": "7c13e64cd017abd44a8f473f61fdf0d1fc41f5a9",
"version-date": "2021-10-05",
"port-version": 0
},…github.com/Neumann-A/vcpkg into use_pkgconf_in_vcpkg_pkgconfig_get_modules
…pkg_pkgconfig_get_modules
…github.com/Neumann-A/vcpkg into use_pkgconf_in_vcpkg_pkgconfig_get_modules
|
Ping @ras0219-msft for reply. |
There was a problem hiding this comment.
LGTM, sorry for the long delay in getting back to this!
A bit more information on why burning it into the file is the correct approach right now: it improves resilience in classic mode under certain (extremely suspect) configurations. It has no effect on manifest mode and as @BillyONeal mentioned we currently include the triplet names into the ABIs so it doesn't introduce any dependence that isn't already present.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
removed
the
requires:vcpkg-team-review
…pkgconf_in_vcpkg_pkgconfig_get_modules
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/vcpkg-pkgconfig-get-modules/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
No description provided.