Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphviz] new port #20564

Merged
merged 11 commits into from
Oct 13, 2021
Merged

[graphviz] new port #20564

merged 11 commits into from
Oct 13, 2021

Conversation

Ace314159
Copy link
Contributor

This adds the graphviz port

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 37d7f96823e611efdca1d7e256f267aa00aa4285
-- New SHA: 4bbd6335a4139353058c782566e6e83f3fab784e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/graphviz/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 9e2375b27a517008eaa137b6e3653a891f543ae2
-- New SHA: 55bd07fbce65294c134c67411b6a4e2a843d5a80
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@Ace314159 Ace314159 marked this pull request as ready for review October 7, 2021 18:11
@PhoebeHui PhoebeHui self-assigned this Oct 8, 2021
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 8, 2021
ports/graphviz/vcpkg.json Outdated Show resolved Hide resolved
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for graphviz but no changes to version or port version.
-- Version: 2.47.3
-- Old SHA: 28b9cc63b06eb8e7d7325eea4c9a73884231fbba
-- New SHA: 2c0b4bb82c5de30956a3adfe87b34230af608e75
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@PhoebeHui
Copy link
Contributor

LGTM, thanks for your PR!

Noted that graphviz passed with x86-windows x64-windows, x64-osx and x64-linux in CI testing, it cascaded with others triplets(x64-windows-static, x64-windows-static-md, x64-uwp, arm-uwp and arm64-windows) due to the dependency port pango and getopt cascaded.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 9, 2021
@BillyONeal
Copy link
Member

In my experience graphviz is generally only used in tool form rather than as a library, making it a somewhat poor fit for the builtin catalog. Do you @Ace314159 do you have example(s) using it as a library rather than as a tool?

(Note that we have rejected attempts to add gcc before for similar reasons even though we have llvm because llvm is often used as a library while gcc is not)

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 12, 2021
@Ace314159
Copy link
Contributor Author

Ace314159 commented Oct 12, 2021

@BillyONeal Graphviz is a dependency for Gazebo, which is an important simulation library commonly used with ROS2. This will make building Gazebo and using it much easier when using ROS2 on Windows.

@BillyONeal BillyONeal added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 12, 2021
@BillyONeal
Copy link
Member

@Ace314159 Thanks!

@vicroms vicroms merged commit e1f8d3a into microsoft:master Oct 13, 2021
@vicroms
Copy link
Member

vicroms commented Oct 13, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add graphviz
4 participants