Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help assimp find vcpkg's copy of zlib so it does not build its own #2093

Merged

Conversation

mcgoo
Copy link
Contributor

@mcgoo mcgoo commented Oct 31, 2017

Without this, assimp uses its internal copy of zlib so the port installs zlibstatic.lib.

@alexkaratarakis alexkaratarakis merged commit e663b69 into microsoft:master Nov 1, 2017
@alexkaratarakis
Copy link
Contributor

Thanks! I bumped the version in the CONTROL file.

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Nov 1, 2017

After further investigation, I discovered the true culprit is that assimp was overwriting the CMAKE_PREFIX_PATH variable, preventing it from finding any libraries inside vcpkg. I've pushed a fix for that as 4.0.1-2.

Note that the fix in 4.0.1-1 causes the release zlib.lib to be linked in Debug mode, so I recommend updating to 4.0.1-2 instead.

@mcgoo mcgoo deleted the make_assimp_use_zlib_from_vcpkg branch November 1, 2017 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants