[vcpkg] Small fixes to vcpkg_build_make #21296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:vcpkg-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@plq, thanks for the PR! could apply the following patch and submit the changes again? |
PhoebeHui
changed the title
Change-Id: I44c39663c397cbdeadf1b875ee7e6e1c781add05
Change-Id: I1f401256b2f4e600a1216de499f044ea3c5a2130
|
cc @Neumann-A for review this PR togather. |
JackBoosY
reviewed
Nov 24, 2021
| @@ -132,7 +136,7 @@ function(vcpkg_build_make) | |||
| set(path_suffix "") | |||
| endif() | |||
|
|
|||
| set(working_directory "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}${short_buildtype}${arg_SUBPATH}") | |||
| set(working_directory "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}${short_buildtype}/${arg_SUBPATH}") | |||
There was a problem hiding this comment.
That's correct, since no port use this options, this issue is hidden under the sea.
JackBoosY
approved these changes
Nov 24, 2021
JackBoosY
added
category:documentation
|
Thanks for the typo fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Which triplets are supported?
all
Have you updated the CI baseline?
no
Does your PR follow the maintainer guide?
seems so
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?no port additions