Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plplot] no absolute paths #21303

Merged
merged 1 commit into from
Nov 13, 2021
Merged

[plplot] no absolute paths #21303

merged 1 commit into from
Nov 13, 2021

Conversation

autoantwort
Copy link
Contributor

For #20469

NancyLi1013
NancyLi1013 suggested changes Nov 11, 2021
View reviewed changes
ports/plplot/vcpkg.json Outdated Show resolved Hide resolved
ports/plplot/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Nov 11, 2021
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 12, 2021
@dan-shaw dan-shaw merged commit a5ff5cd into microsoft:master Nov 13, 2021
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Nov 24, 2021
@BillyONeal
[plplot] Correct control of wxwidgets probably broken by microsoft#21303
4502f70 


This caused wxwidgets to get set on as far as the upstream build system cares if wxwidgets was built first regardless of the feature setting, which broke in CI with unresolved external symbol errors in wxwidgets' internals.
@BillyONeal BillyONeal mentioned this pull request Nov 24, 2021
Merged
BillyONeal added a commit that referenced this pull request Nov 24, 2021
@BillyONeal
[plplot] Correct control of wxwidgets probably broken by #21303 (#21636)
8e4cfac 
This caused wxwidgets to get set on as far as the upstream build system cares if wxwidgets was built first regardless of the feature setting, which broke in CI with unresolved external symbol errors in wxwidgets' internals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @NancyLi1013 @dan-shaw