Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opencascade] Update to 7.6.0 #21314

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

Cheney-W
Copy link
Contributor

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 11, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2021
@dan-shaw dan-shaw merged commit 8cfe802 into microsoft:master Nov 13, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Nov 23, 2021

For the record, this update causes the osg regression in vcpkg.ci.

From https://dev.opencascade.org/doc/overview/html/occt__upgrade.html#upgrade_occt760:

Poly_Triangulation does no more provide access to internal array structures: methods Nodes(), ChangeNode(), Triangles(), ChangeTriangle(), UVNodes(), ChangeUVNode(), Normals() have been removed. Methods of Poly_Triangulation for accessing individual nodal properties / triangles by index and implementing copy semantics should be used instead. The same is applicable to Poly_PolygonOnTriangulation interface.

osg regression:
D:\buildtrees\osg\src\raph-3.6.5-0028e69d98.clean\src\osgPlugins\OpenCASCADE\ReaderWriterOpenCASCADE.cpp(214,49): error C2039: 'Nodes': is not a member of 'Poly_Triangulation' [D:\buildtrees\osg\x64-windows-static-md-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj]

Note that port osg doesn't have a port opencascade dependency. That's why it wasn't uncovered by CI.

This issue needs action in port osg. Maybe port osg has additional auto-detected dependencies. They must be control by vcpkg packaging.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 24, 2021

This issue needs action in port osg. Maybe port osg has additional auto-detected dependencies. They must be control by vcpkg packaging.

Fixed in #21634.

@Cheney-W Cheney-W deleted the Dev/Cheney/opencascade branch August 30, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opencascade] Bump version 7.5.0 -> 7.6.0
4 participants