Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spatialite-tools] Revise and update to 5.0.1 #21594

Merged
merged 11 commits into from
Dec 7, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 22, 2021

  • What does your PR fix?

    Updates spatialite-tools to 5.0.1.
    Revises the dependencies. Uses pkgconfig to detect libraries for nmake and autotools builds.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 22, 2021

Needs readosm.pc for windows.

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 22, 2021

Windows:

cl shell.obj /libpath:D:/installed/x64-windows/debug/lib libexpatd.lib libxml2.lib readosm.lib spatialite.lib sqlite3.lib  /Fespatialite.exe
cl : Command line warning D9002 : ignoring unknown option '/libpath:D:/installed/x64-windows/debug/lib'
...
LINK : fatal error LNK1104: cannot open file 'libexpatd.lib'

Needs to switch to link.exe, or pass option explicitly as linker option.

Linux:

/mnt/vcpkg-ci/buildtrees/spatialite-tools/x64-linux-dbg/./../src/te-tools-5-5df5019d00.clean/shell.c:993: undefined reference to `readline'

Can't properly opt out of system lib readline, perhaps due to include chain?

@JonLiu1993 JonLiu1993 self-assigned this Nov 22, 2021
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision and removed category:port-update The issue is with a library, which is requesting update new revision labels Nov 22, 2021
@JonLiu1993 JonLiu1993 assigned JackBoosY and unassigned JonLiu1993 Nov 22, 2021
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Nov 22, 2021
@dg0yt dg0yt marked this pull request as ready for review November 23, 2021 18:43
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 23, 2021

In its current form this PR includes #21599, minus the added spatialite-tools:x64-windows-static-md=fail which is obsolete with all these changes.

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 2, 2021

@PhoebeHui kindly pinging for review. Blocks proj update.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double checked, everything in .pc is correct.

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 3, 2021
ports/readosm/portfile.cmake Show resolved Hide resolved
ports/readosm/portfile.cmake Show resolved Hide resolved
@BillyONeal BillyONeal merged commit 4c9b301 into microsoft:master Dec 7, 2021
@BillyONeal
Copy link
Member

Thanks for the update!

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 7, 2021

Thanks a lot for merging. I hope I can now proceed with improving proj and the greatest nmake monster, gdal.

@dg0yt dg0yt deleted the spatialite-tools branch December 7, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants