Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ompl] Fix config for find_package #21864

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Conversation

Ace314159
Copy link
Contributor

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Ace314159 Ace314159 changed the title Fix ompl config [ompl] Fix config for find_package Dec 5, 2021
@JonLiu1993 JonLiu1993 self-assigned this Dec 6, 2021
@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Dec 6, 2021
@JackBoosY JackBoosY self-assigned this Dec 6, 2021
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Dec 6, 2021
ports/ompl/vcpkg.json Outdated Show resolved Hide resolved
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63e935d967a3410e26bf4a708efa39d8384d2bbb -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/o-/ompl.json b/versions/o-/ompl.json
index 8a5584e..6e2fbc5 100644
--- a/versions/o-/ompl.json
+++ b/versions/o-/ompl.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "55fdebdea02caaa9252c3e036fb360fa0cd5f79b",
-      "version-string": "1.5.1",
+      "git-tree": "cde8f8a96e5fc3c5764ca85632efa1b828868e26",
+      "version": "1.5.1",
       "port-version": 4
     },
     {

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 6, 2021
@BillyONeal BillyONeal merged commit 80be868 into microsoft:master Dec 7, 2021
@BillyONeal
Copy link
Member

Thanks for the fix :)

@Ace314159 Ace314159 deleted the fix-ompl branch December 7, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ompl] Can't find_package ompl
4 participants