[python3] Install pkg-config files on Windows platforms #22198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JackBoosY
added
the
category:port-feature
Hoikas
reviewed
Dec 26, 2021
|
Thanks for your PR. Please run command |
Fixed now |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LilyWangLL
approved these changes
Dec 29, 2021
mkhon
changed the title
BillyONeal
reviewed
Dec 29, 2021
ports/python3/portfile.cmake
Outdated
| @@ -158,6 +159,30 @@ if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP) | |||
| ) | |||
| endif() | |||
|
|
|||
| vcpkg_backup_env_variables(VARS prefix exec_prefix libdir includedir VERSION) | |||
There was a problem hiding this comment.
Maybe I'm confused by my understanding is that configure_file only looks at CMake variables, not environment variables, so this call to vcpkg_backup_env_variables and vcpkg_restore_env_variables doesn't seem to have an effect?
There was a problem hiding this comment.
Ping @mkhon for response.
There was a problem hiding this comment.
Yes, @BillyONeal is right - I updated the PR
BillyONeal
added
requires:author-response
and removed
info:reviewed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install pkg-config configuration files on Windows platforms (msbuild builds)
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/