Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wxwidgets] no absolute paths #22334

Merged
merged 1 commit into from
Jan 6, 2022
Merged

[wxwidgets] no absolute paths #22334

merged 1 commit into from
Jan 6, 2022

Conversation

autoantwort
Copy link
Contributor

For #20469

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 4, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2022
@strega-nil-ms strega-nil-ms added requires:discussion requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines requires:discussion labels Jan 6, 2022
strega-nil-ms
strega-nil-ms approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love how this works right now, but this isn't making anything worse, so LGTM!

@strega-nil-ms strega-nil-ms merged commit bafaf75 into microsoft:master Jan 6, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoantwort @strega-nil-ms @LilyWangLL @JackBoosY