Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdformat10] no absolute paths #22340

Merged
merged 1 commit into from
Jan 21, 2022
Merged

[sdformat10] no absolute paths #22340

merged 1 commit into from
Jan 21, 2022

Conversation

autoantwort
Copy link
Contributor

For #20469

@PhoebeHui PhoebeHui self-assigned this Jan 5, 2022
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Jan 5, 2022
PhoebeHui
PhoebeHui approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2022
@PhoebeHui PhoebeHui added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 5, 2022
@autoantwort autoantwort force-pushed the sdformat10-no-absolute branch from 7478a9a to d79586e Compare January 5, 2022 14:13
PhoebeHui
PhoebeHui approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 6, 2022
@strega-nil-ms strega-nil-ms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 6, 2022
strega-nil-ms
strega-nil-ms suggested changes Jan 7, 2022
View reviewed changes
ports/sdformat10/portfile.cmake Outdated Show resolved Hide resolved
@strega-nil-ms strega-nil-ms added requires:author-response and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:reviewed Pull Request changes follow basic guidelines labels Jan 7, 2022
@autoantwort autoantwort force-pushed the sdformat10-no-absolute branch from d79586e to 81266e5 Compare January 20, 2022 18:35
github-actions[bot]
github-actions bot requested changes Jan 20, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout 1028f966a3dd736017c1e032972a2dcbfc678f00 -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/s-/sdformat10.json b/versions/s-/sdformat10.json
index 94b7af0..cadd694 100644
--- a/versions/s-/sdformat10.json
+++ b/versions/s-/sdformat10.json
@@ -5,11 +5,6 @@
       "version": "10.0.7",
       "port-version": 0
     },
-    {
-      "git-tree": "a86a4df9ebd26cfc32e4cc0363ecbeb0ca1181dc",
-      "version": "10.0.0",
-      "port-version": 2
-    },
     {
       "git-tree": "13fbbc3bb6bf9c38cb97d4e14af7c3a46ecba6e6",
       "version-string": "10.0.0",

@autoantwort autoantwort force-pushed the sdformat10-no-absolute branch from 81266e5 to 35df20e Compare January 20, 2022 18:37
@autoantwort autoantwort force-pushed the sdformat10-no-absolute branch from 35df20e to d68a69d Compare January 20, 2022 18:38
github-actions[bot]
github-actions bot requested changes Jan 20, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout 1028f966a3dd736017c1e032972a2dcbfc678f00 -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/s-/sdformat10.json b/versions/s-/sdformat10.json
index ad19dae..00cd924 100644
--- a/versions/s-/sdformat10.json
+++ b/versions/s-/sdformat10.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "345a6d5913a7fd66bee569856ee581f0d6a85e5e",
-      "version": "10.0.7",
-      "port-version": 0
-    },
     {
       "git-tree": "abf1fc376b102a9ef833522a615261e5d3e155b8",
       "version": "10.0.0",

PhoebeHui
PhoebeHui approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 21, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit d9118cf into microsoft:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms requested changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @strega-nil-ms @PhoebeHui