[co] Rename port co to cocoyaxi #22442

idealvin · 2022-01-09T14:35:49Z

Describe the pull request

What does your PR fix?

Rename co to cocoyaxi.

Which triplets are supported/not supported? Have you updated the CI baseline?

<all / linux, windows, ...>,
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

<Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Warning: Local port files SHA is the same as version `2.0.3#1` in `/home/runner/work/vcpkg/vcpkg/versions/c-/cocoyaxi.json`.
-- SHA: a0a36b89728f2f3b402ca7a7e41070d3bfcf5add
-- Did you remember to commit your changes?
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 160dd96..07451de 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1444,9 +1444,13 @@
       "baseline": "1.1.7",
       "port-version": 1
     },
+    "co": {
+      "baseline": "2.0.3",
+      "port-version": 0
+    },
     "cocoyaxi": {
       "baseline": "2.0.3",
-      "port-version": 1
+      "port-version": 0
     },
     "coin": {
       "baseline": "4.0.0",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 160dd96..26660f7 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1444,6 +1444,10 @@
       "baseline": "1.1.7",
       "port-version": 1
     },
+    "co": {
+      "baseline": "2.0.3",
+      "port-version": 0
+    },
     "cocoyaxi": {
       "baseline": "2.0.3",
       "port-version": 1

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 160dd96..26660f7 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1444,6 +1444,10 @@
       "baseline": "1.1.7",
       "port-version": 1
     },
+    "co": {
+      "baseline": "2.0.3",
+      "port-version": 0
+    },
     "cocoyaxi": {
       "baseline": "2.0.3",
       "port-version": 1

LilyWangLL · 2022-01-10T07:45:24Z

Thanks for posting this issue. VCPKG use supports in vcpkg.json instead of vcpkg_fail_port_install. Could you please remove there codes in portfile.cmake?

if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

And if you rename co to cocoyaxi, you need also rename the directory name VCPKG_ROOT/ports/co to VCPKG_ROOT/ports/cocoyaxi.

idealvin · 2022-01-10T13:32:09Z

Thanks for posting this issue. VCPKG use supports in vcpkg.json instead of vcpkg_fail_port_install. Could you please remove there codes in portfile.cmake?
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()
And if you rename co to cocoyaxi, you need also rename the directory name VCPKG_ROOT/ports/co to VCPKG_ROOT/ports/cocoyaxi.

@LilyWangLL
Hi, I think I have already renamed it to cocoyaxi. But I don't know how to use supports instead of vcpkg_fail_port_install. Could you help? Thanks!

LilyWangLL · 2022-01-11T03:47:32Z

@idealvin You just need remove these codes in portfile.cmake.

if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

idealvin · 2022-01-11T04:04:40Z

@idealvin You just need remove these codes in portfile.cmake.
if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
    vcpkg_fail_port_install(ON_ARCH "arm" ON_TAREGT "uwp")
endif()

ok, I removed it..

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index e88b3fd..cd37752 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1444,6 +1444,10 @@
       "baseline": "1.1.7",
       "port-version": 1
     },
+    "co": {
+      "baseline": "2.0.3",
+      "port-version": 0
+    },
     "cocoyaxi": {
       "baseline": "2.0.3",
       "port-version": 1

strega-nil-ms

This PR is incorrect since it removes history; it should've been caught by CI.

The correct way to rename a port is to have an empty port under the old name, which depends only on the new port. The new port's version.json should only contain the latest version.

What you need to do here is:

restore co as an empty port which depends only on cocoyaxi
restore versions/c-/co.json
have only the latest version of cocoyaxi in versions/c-/cocoyaxi.json

LilyWangLL · 2022-01-14T08:29:17Z

@idealvin You could download and unzip the attached file co.zip, then put directory co into VCPKG_ROOT/ports, and put co.json into VCPKG_ROOT/versions/c-.
co.zip

idealvin · 2022-01-14T08:35:45Z

@idealvin You could download and unzip the attached file co.zip, then put directory co into VCPKG_ROOT/ports, and put co.json into VCPKG_ROOT/versions/c-. co.zip

@LilyWangLL ok，thanks! I'll try later. A little busy these days.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 74f52cf..9aea936 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1444,6 +1444,10 @@
       "baseline": "1.1.7",
       "port-version": 1
     },
+    "co": {
+      "baseline": "2.0.3",
+      "port-version": 1
+    },
     "cocoyaxi": {
       "baseline": "2.0.3",
       "port-version": 1
diff --git a/versions/c-/co.json b/versions/c-/co.json
index 6f33ba6..f5291d2 100644
--- a/versions/c-/co.json
+++ b/versions/c-/co.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "a45d20b421153f71deffc2dc4da7fd37143b297d",
+      "git-tree": "569af78fe06ff14cd71ec70f14915d06344ed62b",
       "version-semver": "2.0.3",
       "port-version": 1
     },

idealvin · 2022-01-17T05:05:32Z

This PR is incorrect since it removes history; it should've been caught by CI.

The correct way to rename a port is to have an empty port under the old name, which depends only on the new port. The new port's version.json should only contain the latest version.

What you need to do here is:

restore co as an empty port which depends only on cocoyaxi

restore versions/c-/co.json

have only the latest version of cocoyaxi in versions/c-/cocoyaxi.json

@strega-nil-ms Done. Thanks.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 03ca9b59af1506a86840e3a3a01a092f3333a29b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/co.json b/versions/c-/co.json
index dd7c8e5..f5291d2 100644
--- a/versions/c-/co.json
+++ b/versions/c-/co.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "569af78fe06ff14cd71ec70f14915d06344ed62b",
+      "version-semver": "2.0.3",
+      "port-version": 1
+    },
     {
       "git-tree": "812bf72c24739504b6ddc3d3c4d941981ff3a032",
       "version-semver": "2.0.3",

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

ports/co/vcpkg.json
ports/cocoyaxi/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

ports/co/vcpkg.json
ports/cocoyaxi/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Missed in microsoft#22442 due to artifact caching.

Missed in #22442 due to artifact caching.

idealvin added 2 commits January 9, 2022 22:29

rename port co to cocoyaxi

3a9eb0e

update version

46e47f0

github-actions bot requested changes Jan 9, 2022

View reviewed changes

idealvin added 2 commits January 9, 2022 22:46

update port version

84db448

update sha

11e91c9

github-actions bot requested changes Jan 9, 2022

View reviewed changes

idealvin added 2 commits January 9, 2022 22:52

rename co to cocoyaxi

9cd7eee

update sha

5495acd

github-actions bot requested changes Jan 9, 2022

View reviewed changes

JonLiu1993 assigned LilyWangLL Jan 10, 2022

LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 10, 2022

LilyWangLL changed the title ~~Rename port co to cocoyaxi~~ [co] Rename port co to cocoyaxi Jan 10, 2022

LilyWangLL added the requires:author-response label Jan 10, 2022

idealvin added 2 commits January 11, 2022 12:02

cleanup portfile for cocoyaxi

ad9c3b3

update sha

af86661

github-actions bot requested changes Jan 11, 2022

View reviewed changes

LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 11, 2022

strega-nil-ms suggested changes Jan 11, 2022

View reviewed changes

strega-nil-ms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 11, 2022

add co

048844a

github-actions bot requested changes Jan 14, 2022

View reviewed changes

update version for co

2694fe0

github-actions bot approved these changes Jan 14, 2022

View reviewed changes

LilyWangLL approved these changes Jan 14, 2022

View reviewed changes

LilyWangLL removed the requires:author-response label Jan 17, 2022

LilyWangLL requested a review from strega-nil-ms January 17, 2022 05:43

LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 20, 2022

github-actions bot requested changes Jan 20, 2022

View reviewed changes

fix version files

bd57ec0

strega-nil-ms force-pushed the master branch from 32a9142 to bd57ec0 Compare January 20, 2022 22:11

github-actions bot approved these changes Jan 20, 2022

View reviewed changes

strega-nil-ms merged commit 20f8760 into microsoft:master Jan 20, 2022

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Feb 9, 2022

[cocoyaxi] Fix SHA.

6ea6e9b

Missed in microsoft#22442 due to artifact caching.

BillyONeal mentioned this pull request Feb 9, 2022

[cocoyaxi] Fix SHA. #23007

Merged

BillyONeal added a commit that referenced this pull request Feb 9, 2022

[cocoyaxi] Fix SHA. (#23007)

bd8a0df

Missed in #22442 due to artifact caching.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[co] Rename port co to cocoyaxi #22442

[co] Rename port co to cocoyaxi #22442

idealvin commented Jan 9, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

LilyWangLL commented Jan 10, 2022

idealvin commented Jan 10, 2022

LilyWangLL commented Jan 11, 2022

idealvin commented Jan 11, 2022

github-actions bot left a comment

strega-nil-ms left a comment

LilyWangLL commented Jan 14, 2022

idealvin commented Jan 14, 2022

github-actions bot left a comment

idealvin commented Jan 17, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

[co] Rename port co to cocoyaxi #22442

[co] Rename port co to cocoyaxi #22442

Conversation

idealvin commented Jan 9, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

LilyWangLL commented Jan 10, 2022

idealvin commented Jan 10, 2022

LilyWangLL commented Jan 11, 2022

idealvin commented Jan 11, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

strega-nil-ms left a comment

Choose a reason for hiding this comment

LilyWangLL commented Jan 14, 2022

idealvin commented Jan 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

idealvin commented Jan 17, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

idealvin commented Jan 17, 2022 •

edited

Loading